feat(node): pull node binaries into separate packages (2)#197
Merged
Conversation
gsilvestrin
changed the title
gsilvestrin
force-pushed
the
gsilvestrin/nodejs_native_round2
branch
from
June 15, 2023 21:16
35bc144 to
5cca04f
Compare
gsilvestrin
commented
Jun 15, 2023
| @@ -0,0 +1,4 @@ | |||
| gen_test_data.py | |||
Contributor
Author
gsilvestrin
marked this pull request as ready for review
June 15, 2023 21:31
wjones127
reviewed
Jun 15, 2023
Comment on lines
+50
to
+53
| "vectordb-darwin-arm64": "0.1.2", | ||
| "vectordb-darwin-x64": "0.1.2", | ||
| "vectordb-linux-arm64-gnu": "0.1.2", | ||
| "vectordb-linux-x64-gnu": "0.1.2" |
Contributor
There was a problem hiding this comment.
Does our increment version script handle incrementing these versions?
Contributor
Author
There was a problem hiding this comment.
Good catch, let me update it
Contributor
Author
There was a problem hiding this comment.
Done - versions are in sync now
wjones127
reviewed
Jun 15, 2023
wjones127
left a comment
wjones127
left a comment
Contributor
There was a problem hiding this comment.
Looks good. My main question is whether the version bump script handles the native sub packages.
Changes: * Refactors the Node module to load the shared library from a separate package. When a user does `npm install vectordb`, the correct optional dependency is automatically downloaded by npm. * Brings Rust and Node versions in alignment at 0.1.2. * Add scripts and instructions to build Linux and MacOS node artifacts locally. * Add instructions for publishing the npm module and crates.
- Changed the publish task to run after a release is published - removed bump versions scripts since they are handled by another task - removed organization (@lance) from packages
gsilvestrin
force-pushed
the
gsilvestrin/nodejs_native_round2
branch
from
June 15, 2023 21:57
5cca04f to
d34960a
Compare
wjones127
approved these changes
Jun 15, 2023
Contributor
Author
|
submitting this issue with improve bumping versions: #201 |
gsilvestrin
pushed a commit
that referenced
this pull request
Jun 17, 2023
…)" This reverts commit 0724d41.
raghavdixit99
pushed a commit
to raghavdixit99/lancedb
that referenced
this pull request
Apr 5, 2024
* Refactors the Node module to load the shared library from a separate package. When a user does `npm install vectordb`, the correct optional dependency is automatically downloaded by npm. * Add scripts and instructions to build Linux and MacOS node artifacts locally. * Add instructions for publishing the npm module and crates. Co-authored-by: Will Jones <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Changes
Previous Changes
package. When a user does
npm install vectordb, the correct optionaldependency is automatically downloaded by npm.
locally.