Repository navigation
Commit 62fbc0f
authored
build: ship a static-CRT Windows package (#217)
Windows release DLLs currently depend on the VC Runtime installed on the
build host. This change selects static CRT linkage across the Rust and
native dependency graph, preserves the exact public export policy, and
makes the installed static-library contract explicitly Release `/MT`.
The CMake source build defaults to static CRT for Windows MSVC and
supports an explicit opt-out. Windows prebuilt installs must declare
`LANCE_C_CRT_STATIC=ON` or `OFF` to match their input; installation does
not convert libraries. The package exposes `LanceC_STATIC_CRT`, and
consumers select their CRT explicitly. The stale Corrosion dynamic-CRT
directive is removed without `/NODEFAULTLIB` or warning suppression.
Direct Cargo builds still need their own documented CRT flag.
Validation of `335dbacad90786a486ac69e7f9bf089ab63ea751` in [run
43167179892](https://github.com/lance-format/lance-c/actions/runs/43167179892):
- Native Windows Server 2022 x64 and Windows 11 ARM64, Rust 1.94.0: full
Release build/install and static/shared consumers passed. Consumers
exercised create/reopen/scan, Arrow callback ownership, error strings
and clone lifetime.
- Both artifacts contain exactly 878 header-declared DLL exports and 878
import-library symbols, 16 distinct OS/API-set dependencies and no delay
imports. Static archive and consumer CRT checks passed without
CRT-conflict warnings. Loaded-module guards rejected redistributable
runtime families while allowing the exact Windows OS modules
`msvcp_win.dll` and `msvcrt.dll`.
- Missing/ON/OFF prebuilt-CRT configuration tests passed on both
architectures. Downloaded ZIP hashes, PE machines, export/import sets,
dependency tables, installed headers and `LanceC_STATIC_CRT=ON` were
independently checked.
- macOS Rust/native tests and installed static/shared consumers passed.
Intel build, staging guards and installed consumers were reported
successful before the runner lost communication during artifact upload;
its overall job failed and no final Intel artifact is claimed.
- Linux and Clippy failed at dependency installation before exercising
project code. The inherited mirror problem was separately fixed and
validated in merged #218. Main's only delta since this candidate's base
is that four-job Ubuntu mirror repair; Rust inputs and the Windows
package path are unchanged. These failed jobs are not reported as
passing.
Artifact ZIP SHA-256: x64
`fe61e185210f25d6aae94bf4b8eedc857227d043e659e397edba82b24a69cbef`;
ARM64
`676b7530f36b5c84d71495d13c4eded35864d4b504f48f520c992f4c4ef4b76c`.
This establishes the native package contract on the exercised OS
baselines. It does not claim a fresh-machine lab, older Windows support,
a published release, or downstream Go adoption. The Lance pin, native
source and public ABI are unchanged.
Fixes #215. Part of #174.1 parent 26d29ba commit 62fbc0f
12 files changed
Lines changed: 565 additions & 39 deletions
File tree
- .github
- scripts
- workflows
- cmake
- examples/cmake-consumer
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
43 | 117 | | |
44 | 118 | | |
45 | 119 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
48 | 49 | | |
49 | 50 | | |
50 | 51 | | |
| |||
53 | 54 | | |
54 | 55 | | |
55 | 56 | | |
56 | | - | |
| 57 | + | |
| 58 | + | |
57 | 59 | | |
58 | 60 | | |
59 | 61 | | |
| |||
63 | 65 | | |
64 | 66 | | |
65 | 67 | | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
66 | 73 | | |
67 | 74 | | |
68 | 75 | | |
| |||
168 | 175 | | |
169 | 176 | | |
170 | 177 | | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
178 | 181 | | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
179 | 188 | | |
180 | 189 | | |
181 | | - | |
| 190 | + | |
182 | 191 | | |
183 | 192 | | |
184 | 193 | | |
185 | 194 | | |
186 | 195 | | |
187 | 196 | | |
188 | | - | |
| 197 | + | |
189 | 198 | | |
190 | 199 | | |
191 | | - | |
| 200 | + | |
192 | 201 | | |
193 | 202 | | |
194 | | - | |
| 203 | + | |
195 | 204 | | |
196 | 205 | | |
197 | 206 | | |
198 | 207 | | |
199 | 208 | | |
200 | 209 | | |
201 | | - | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
202 | 249 | | |
203 | 250 | | |
204 | 251 | | |
| |||
226 | 273 | | |
227 | 274 | | |
228 | 275 | | |
229 | | - | |
| 276 | + | |
| 277 | + | |
230 | 278 | | |
231 | 279 | | |
232 | 280 | | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
233 | 288 | | |
234 | 289 | | |
235 | 290 | | |
236 | 291 | | |
237 | 292 | | |
238 | 293 | | |
239 | 294 | | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
240 | 330 | | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
241 | 339 | | |
242 | 340 | | |
243 | | - | |
| 341 | + | |
244 | 342 | | |
245 | 343 | | |
246 | | - | |
| 344 | + | |
247 | 345 | | |
248 | 346 | | |
249 | 347 | | |
| |||
254 | 352 | | |
255 | 353 | | |
256 | 354 | | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
257 | 358 | | |
258 | 359 | | |
| 360 | + | |
259 | 361 | | |
260 | 362 | | |
261 | 363 | | |
262 | 364 | | |
263 | 365 | | |
264 | 366 | | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
265 | 395 | | |
| 396 | + | |
| 397 | + | |
266 | 398 | | |
267 | 399 | | |
268 | 400 | | |
| |||
0 commit comments