Skip to content

fix(ci): backport cargo publish fix to release/v9.0#7990

Merged
wjones127 merged 2 commits into
lance-format:release/v9.0from
wjones127:backport/cargo-publish-readme-v9.0
Jul 24, 2026
Merged

fix(ci): backport cargo publish fix to release/v9.0#7990
wjones127 merged 2 commits into
lance-format:release/v9.0from
wjones127:backport/cargo-publish-readme-v9.0

Conversation

@wjones127

Copy link
Copy Markdown
Contributor

Backport of #7989 so the 9.0.x line can publish to crates.io.

cargo publish --workspace aborted on the 9.0.0 release because lance-index-core declared a readme that does not exist, and it packages every crate before uploading any, so nothing reached crates.io. Without this, 9.0.1 would fail the same way.

Fixes #7986

The 9.0.0 crates.io publish failed because lance-index-core declared a
readme that did not exist. Nothing in CI packages the crates, so the
problem only surfaced during the release. Add a `cargo package
--no-verify` job that mirrors the publish command.
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Pro Plus

Run ID: 907bbeaa-f223-4abc-abc7-e66c49bdeb64

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added A-ci CI / build workflows bug Something isn't working labels Jul 24, 2026

@Xuanwo Xuanwo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wjones127
wjones127 marked this pull request as ready for review July 24, 2026 18:19
@wjones127
wjones127 merged commit d293630 into lance-format:release/v9.0 Jul 24, 2026
34 checks passed
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci CI / build workflows bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants