fix(ci): unblock cargo publish and dry-run packaging in CI#7989
Merged
Conversation
The 9.0.0 crates.io publish failed because lance-index-core declared a readme that did not exist. Nothing in CI packages the crates, so the problem only surfaced during the release. Add a `cargo package --no-verify` job that mirrors the publish command.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Rust workflow adds a workspace packaging validation job, and ChangesRust packaging
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
wjones127
added a commit
that referenced
this pull request
Jul 24, 2026
Backport of #7989 so the 9.0.x line can publish to crates.io. `cargo publish --workspace` aborted on the 9.0.0 release because `lance-index-core` declared a readme that does not exist, and it packages every crate before uploading any, so nothing reached crates.io. Without this, 9.0.1 would fail the same way. Fixes #7986
wjones127
marked this pull request as ready for review
July 24, 2026 18:19
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 9.0.0 crates.io publish failed while packaging
lance-index-core:The crate was added in #7713 with
readme = "README.md"but no such file.cargo publish --workspacepackages every crate before uploading any, so the whole release aborted and no 9.0.0 crates reached crates.io.Two changes:
rust/lance-index-core/README.md, matching the sibling internal crates.cargo package --workspace --no-verifyjob to the Rust workflow. Nothing in CI packaged the crates, so manifest problems that only surface at publish time (missing readme/license files, path dependencies without a version) were invisible until the release ran.--no-verifyskips rebuilding each packaged crate, which the other jobs already cover, so the job takes about a minute.Verified locally: all 25 publishable crates now package cleanly.
Fixes #7986