fix(fts): preserve parameter compatibility#7874
Merged
Merged
Conversation
github-actions
Bot
added
A-index
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughInverted-index parameter deserialization now ignores unknown JSON fields. Tests verify this behavior for training JSON normalization and metadata-based parameter loading. ChangesInverted-index parameter compatibility
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Xuanwo
marked this pull request as ready for review
July 21, 2026 04:15
BubbleCal
approved these changes
Jul 21, 2026
wjones127
pushed a commit
that referenced
this pull request
Jul 21, 2026
`InvertedIndexParams` is persisted in FTS index metadata and shared across Lance versions. PR #7681 added `deny_unknown_fields`, causing existing indexes that still contain retired fields such as `skip_merge` to fail to load. This also breaks `bench_regress` against its existing Wikipedia FTS index. Restore Serde's tolerant-reader behavior so historical and future metadata fields are ignored while validation for recognized parameters remains intact. Regression coverage exercises both training JSON and the on-disk `metadata.lance` loading path. (cherry picked from commit 81cd887)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InvertedIndexParamsis persisted in FTS index metadata and shared across Lance versions. PR #7681 addeddeny_unknown_fields, causing existing indexes that still contain retired fields such asskip_mergeto fail to load. This also breaksbench_regressagainst its existing Wikipedia FTS index.Restore Serde's tolerant-reader behavior so historical and future metadata fields are ignored while validation for recognized parameters remains intact. Regression coverage exercises both training JSON and the on-disk
metadata.lanceloading path.