fix(index): implement with_io_priority for FailNewFileStore test store#7495
Merged
Xuanwo merged 2 commits intoJun 26, 2026
Merged
Conversation
The IndexStore trait gained `with_io_priority` (lance-format#7449), but the FailNewFileStore test fixture added later (lance-format#7422, branched before lance-format#7449 landed) did not implement it, breaking the lance-index test build once both were on main. Delegate to the inner store and re-wrap, preserving the fixture's injected new_index_file failure.
github-actions
Bot
added
A-index
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Add a focused test that calls with_io_priority on the FailNewFileStore fixture and asserts the reprioritized store still injects the new_index_file failure, covering the delegating impl.
Contributor
Author
|
also cc @jackye1995 |
Xuanwo
approved these changes
Jun 26, 2026
Contributor
Author
|
Thank you @Xuanwo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
lance-indextest build is currently broken onmain:error[E0046]: not all trait items implemented, missing: with_io_priorityatrust/lance-index/src/scalar/fmindex.rs.with_io_prioritywas added to theIndexStoretrait in #7449. TheFailNewFileStoretest fixture was added later in #7422 (which branched before #7449 landed), so it never implemented the new method. Each PR was green on its own; together onmainthe test build fails — a semantic merge conflict. It only surfaces in theBuild testsstep because the fixture is#[cfg(test)].Fix
Implement
with_io_priorityonFailNewFileStoreby delegating to the inner store and re-wrapping, mirroring how the fixture already delegates its other read methods while keeping the injectednew_index_filefailure.Verification
cargo check -p lance-index --tests— compiles (was failing onmain).cargo test -p lance-index --lib fmindex— 24 passed.cargo fmt -p lance-index -- --checkandcargo clippy -p lance-index --tests— clean.