fix(rowids): union overlapping segments in RowAddrTreeMap::from#7429
Merged
wjones127 merged 1 commit intoJun 23, 2026
Merged
Conversation
A fragment's RowIdSequence can hold segments whose ranges overlap but whose selected ids are disjoint -- compaction concatenates the surviving and rewritten halves of an updated fragment this way. From applied each segment's bitmap/hole removals to one shared map, so a later segment's removals cleared ids an earlier overlapping segment owned, dropping live rows from the result. Build each segment in isolation and union it in. Surfaced via COUNT(*) pushdown over stable row ids returning 0 after update + compact + filter. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
wjones127
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fragment's RowIdSequence can hold segments whose ranges overlap but whose selected ids are disjoint -- compaction concatenates the surviving and rewritten halves of an updated fragment this way. From applied each segment's bitmap/hole removals to one shared map, so a later segment's removals cleared ids an earlier overlapping segment owned, dropping live rows from the result.
Build each segment in isolation and union it in. Surfaced via COUNT(*) pushdown over stable row ids returning 0 after update + compact + filter.