chore: upgrade itertools to 0.14#7424
Merged
wjones127 merged 1 commit intoJun 23, 2026
Merged
Conversation
wjones127
force-pushed
the
chore/upgrade-itertools-rand
branch
from
June 23, 2026 16:53
91f77ee to
b25d8b2
Compare
DataFusion, object_store, and prost-derive already resolved to itertools 0.14; only our workspace pin held a second 0.13 copy in the graph. Bumping the pin collapses it (criterion keeps 0.13 for dev/bench only). No API changes needed — we use no removed 0.13 items. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
wjones127
force-pushed
the
chore/upgrade-itertools-rand
branch
from
June 23, 2026 16:54
b25d8b2 to
343a97e
Compare
wjones127
changed the title
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
wjones127
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
wjones127
marked this pull request as ready for review
June 23, 2026 17:38
hamersaw
approved these changes
Jun 23, 2026
Xuanwo
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataFusion,
object_store, andprost-derivealready resolved to itertools 0.14, while our workspace pin held a second 0.13 copy in the dependency graph. Bumping the pin to 0.14 collapses the duplicate; onlycriterionretains 0.13, and that is dev/bench-only so it does not affect shipped crates.No source changes were needed — we use no items removed between 0.13 and 0.14.
Verified with
cargo check --workspace --tests --benchesandcargo clippy --all --tests --benches -- -D warnings.Context: this came out of a dependency-graph audit. A
rand0.9 → 0.10 bump was also considered, but dropped —rand0.9 is held alive by DataFusion (and goosefs-sdk/hf-hub/jsonb), so bumping our code to 0.10 would not eliminate the duplicate, only move which copy our code uses. Worth revisiting once DataFusion moves torand0.10.