feat(rust): support datafusion expressions for merge insert predicates#6934
Merged
wjones127 merged 3 commits intoMay 28, 2026
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Ar-maan05
force-pushed
the
feat/merge-insert-expr-support
branch
from
May 26, 2026 17:47
84cb398 to
3a6e755
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
wjones127
requested changes
May 26, 2026
wjones127
left a comment
wjones127
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable, but I have a minor change requested to deduplicate some logic.
wjones127
approved these changes
May 27, 2026
wjones127
left a comment
wjones127
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Can merge once tests are passing.
Contributor
Author
|
CI is green and ready on my end. Let me know if anything else is needed before merge. |
Contributor
Author
|
Hi @wjones127 , just wanted to flag that PR #3444 in lancedb/lancedb extends this same DataFusion work to the lancedb SDK layer; happy to make any adjustments if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for passing logical DataFusion expressions (
datafusion_expr::Expr) directly to the merge insert query planner for conditional updates (WhenMatched::UpdateIfExpr). Currently, matched update predicates only accept SQL strings which are parsed at plan creation time, introducing serialize-deserialize round-trip overhead when callers build expressions programmatically.Key Changes
WhenMatchedEnum: Added theUpdateIfExpr(datafusion_expr::Expr)variant and the associated constructor helperWhenMatched::update_if_expr(expr: Expr).merge_insert.rs): Updated plan generation to optimize the DataFusion logical expression and convert it directly to a physical expression.assign_action.rs(action determination),exec/write.rs(DisplayAs), andlogical_plan.rs(Explain formatting).Verification
lancedb.Closes #6861