chore: suppress humantime advisory#3529
Merged
westonpace merged 2 commits intoMar 12, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3529 +/- ##
==========================================
+ Coverage 78.77% 78.81% +0.03%
==========================================
Files 254 254
Lines 95423 95423
Branches 95423 95423
==========================================
+ Hits 75168 75204 +36
+ Misses 17147 17108 -39
- Partials 3108 3111 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wjones127
approved these changes
Mar 11, 2025
westonpace
force-pushed
the
chore/ignore-humantime-advisory
branch
from
March 11, 2025 22:26
76511c5 to
c978491
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
humantimepackage is no longer maintained. We should move to avoid using it. We were using it indirectly viaenv_loggerandobject_store. This PR updatesenv_loggerto the latest version (which usesjiffinstead ofhumantime).object_storeis one of our core dependencies and we generally update it as new versions are released. If (and when)humantimeis replaced withjiffwe will remove the dependency then. This may be several months. apache/arrow-rs#7261 can be used for tracking.Until then we should suppress the advisory.