ci(python): type checking with pyright#3286
Merged
Merged
Conversation
github-actions
Bot
added
A-python
wjones127
commented
Dec 23, 2024
Comment on lines
-71
to
-75
| [tool.mypy] | ||
| python_version = "3.12" | ||
| check_untyped_defs = true | ||
| warn_redundant_casts = true | ||
| warn_unused_ignores = true |
Contributor
Author
There was a problem hiding this comment.
We don't use mypy. I chose pyright over mypy because it's generally faster. But if anyone has a strong opinion otherwise, I'm happy to hear them out.
wjones127
commented
Dec 23, 2024
Comment on lines
-119
to
+120
| if has_fixed_shape_tensor: | ||
| # Pyarrow compatibility | ||
| shape = (ret.type.list_size,) | ||
| tensor_type = pa.fixed_shape_tensor(ret.type.value_type, shape) | ||
| ret = pa.FixedShapeTensorArray.from_storage(tensor_type, ret) | ||
|
|
||
| shape = (ret.type.list_size,) | ||
| tensor_type = pa.fixed_shape_tensor(ret.type.value_type, shape) | ||
| ret = pa.FixedShapeTensorArray.from_storage(tensor_type, ret) |
Contributor
Author
There was a problem hiding this comment.
PyArrow introducted FixedShapeTensor in 13.0.0, and our minimum pyarrow is now 14.0.0. So don't need to handle older versions now.
wjones127
marked this pull request as ready for review
December 23, 2024 20:48
LuQQiu
approved these changes
Dec 24, 2024
This was referenced Dec 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial step of #3285