Skip to content

Conversation

@ProjectFrank
Copy link
Contributor

Fixes #29.

As advised by clojure CLI warnings
@plexus
Copy link
Member

plexus commented Sep 1, 2022

I'm going to leave this open for now. If we want to put out a bugfix release for deep-diff1 we'd have to start by fixing the CI setup, and bringing our lambdaisland toolchain setup up to date (see bin/proj and bb.edn).

deep-diff2 has been out for a few years, and upgrading should be very straightforward, so unless someone comes around who is running into this issue and for some reason is unable to upgrade, I don't think there's enough reason to put effort into this.

@plexus
Copy link
Member

plexus commented Nov 25, 2022

To clarify for people coming across this issue. The aforementioned bug has been fixed in deep-diff2, this PR is specifically for the old deep-diff(1). We could release a new version of deep-diff1 with the fix, but there's some effort involved, and no one might really need it, so we're punting on this until someone steps up and explains why they need this.

@plexus plexus closed this Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🙈Out of Scope

Development

Successfully merging this pull request may close these issues.

2 participants