refactor(blockchain): drop SyncStatusTracker::gate_proposer

MegaRedHand · MegaRedHand · commit f8d6ec2844e6 · 2026-06-19T19:16:07.000-03:00
gate_proposer was a one-line wrapper over duties_allowed() with a single
call site. Inline it at the call site as
scheduled_proposer.filter(|_| duties_allowed()) and drop the method, so
the sync gate is expressed the same way everywhere. Behavior unchanged.

The three gate_proposer-only tests collapse onto the duties_allowed()
assertions they already carried.
diff --git a/crates/blockchain/src/lib.rs b/crates/blockchain/src/lib.rs
@@ -236,7 +236,8 @@ impl BlockChainServer {
         let scheduled_proposer = (interval == 0 && slot > 0)
             .then(|| self.get_our_proposer(slot))
             .flatten();
-        let proposer_validator_id = self.sync_status.gate_proposer(scheduled_proposer);
+        let proposer_validator_id =
+            scheduled_proposer.filter(|_| self.sync_status.duties_allowed());
 
         if let Some(validator_id) = scheduled_proposer
             && proposer_validator_id.is_none()
diff --git a/crates/blockchain/src/sync_status.rs b/crates/blockchain/src/sync_status.rs
@@ -45,10 +45,6 @@ impl SyncStatusTracker {
     pub(crate) fn duties_allowed(&self) -> bool {
         !self.syncing
     }
-
-    pub(crate) fn gate_proposer(&self, proposer: Option<u64>) -> Option<u64> {
-        proposer.filter(|_| self.duties_allowed())
-    }
 }
 
 #[cfg(test)]
@@ -114,30 +110,27 @@ mod tests {
     }
 
     #[test]
-    fn syncing_gates_proposals_and_attestations() {
+    fn syncing_blocks_duties() {
         let mut tracker = SyncStatusTracker::default();
         tracker.update(20, 0, 20);
 
         assert!(!tracker.duties_allowed());
-        assert_eq!(tracker.gate_proposer(Some(3)), None);
     }
 
     #[test]
-    fn caught_up_node_allows_proposals_and_attestations() {
+    fn caught_up_node_allows_duties() {
         let mut tracker = SyncStatusTracker::default();
         tracker.update(20, 0, 20);
         tracker.update(20, 18, 20);
 
         assert!(tracker.duties_allowed());
-        assert_eq!(tracker.gate_proposer(Some(3)), Some(3));
     }
 
     #[test]
-    fn network_stall_keeps_proposals_and_attestations_enabled() {
+    fn network_stall_keeps_duties_enabled() {
         let mut tracker = SyncStatusTracker::default();
         tracker.update(100, 0, 0);
 
         assert!(tracker.duties_allowed());
-        assert_eq!(tracker.gate_proposer(Some(3)), Some(3));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -45,10 +45,6 @@ impl SyncStatusTracker {`
`45`	`45`	`pub(crate) fn duties_allowed(&self) -> bool {`
`46`	`46`	`!self.syncing`
`47`	`47`	`}`
`48`		`-`
`49`		`- pub(crate) fn gate_proposer(&self, proposer: Option<u64>) -> Option<u64> {`
`50`		`- proposer.filter(\|_\| self.duties_allowed())`
`51`		`- }`
`52`	`48`	`}`
`53`	`49`
`54`	`50`	`#[cfg(test)]`
`@@ -114,30 +110,27 @@ mod tests {`
`114`	`110`	`}`
`115`	`111`
`116`	`112`	`#[test]`
`117`		`- fn syncing_gates_proposals_and_attestations() {`
	`113`	`+ fn syncing_blocks_duties() {`
`118`	`114`	`let mut tracker = SyncStatusTracker::default();`
`119`	`115`	`tracker.update(20, 0, 20);`
`120`	`116`
`121`	`117`	`assert!(!tracker.duties_allowed());`
`122`		`- assert_eq!(tracker.gate_proposer(Some(3)), None);`
`123`	`118`	`}`
`124`	`119`
`125`	`120`	`#[test]`
`126`		`- fn caught_up_node_allows_proposals_and_attestations() {`
	`121`	`+ fn caught_up_node_allows_duties() {`
`127`	`122`	`let mut tracker = SyncStatusTracker::default();`
`128`	`123`	`tracker.update(20, 0, 20);`
`129`	`124`	`tracker.update(20, 18, 20);`
`130`	`125`
`131`	`126`	`assert!(tracker.duties_allowed());`
`132`		`- assert_eq!(tracker.gate_proposer(Some(3)), Some(3));`
`133`	`127`	`}`
`134`	`128`
`135`	`129`	`#[test]`
`136`		`- fn network_stall_keeps_proposals_and_attestations_enabled() {`
	`130`	`+ fn network_stall_keeps_duties_enabled() {`
`137`	`131`	`let mut tracker = SyncStatusTracker::default();`
`138`	`132`	`tracker.update(100, 0, 0);`
`139`	`133`
`140`	`134`	`assert!(tracker.duties_allowed());`
`141`		`- assert_eq!(tracker.gate_proposer(Some(3)), Some(3));`
`142`	`135`	`}`
`143`	`136`	`}`