validate tags given in --between-tags option#93
Merged
lalitkapoor merged 6 commits intolalitkapoor:masterfrom Jan 4, 2021
TheJavaGuy:master
Merged
validate tags given in --between-tags option#93lalitkapoor merged 6 commits intolalitkapoor:masterfrom TheJavaGuy:master
lalitkapoor merged 6 commits intolalitkapoor:masterfrom
TheJavaGuy:master
Conversation
Closed
Owner
|
@TheJavaGuy Hi, Thank you for submitting this! I did a little clean up here. Would you mind giving it a go before I merge. Thanks! (It has been pushed to master on your fork, so feel free to just pull there and give it a go) |
Contributor
Author
|
@lalitkapoor Thank you, it looks good. The only imprecision is, if a user has |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For validation/parsing of command-line option, I opted for printing to
console.errorregardless of--verboseoption because otherwise user might be confused why the program stopped. For checking whether tags really exist, I opted forthrow new Error(...)because it will be caught by top levelcatchinsidetaskfunction. Maybe there is a more elegant solution but I couldn't find it.This PR doesn't actually close issue #84 because supporting raw git repo seems out of scope for
@octokit/corewhich is used to fetch info from GitHub repos.