Skip to content

Update dependencies#83

Closed
ahwayakchih wants to merge 4 commits intolalitkapoor:masterfrom
ahwayakchih:update-deps
Closed

Update dependencies#83
ahwayakchih wants to merge 4 commits intolalitkapoor:masterfrom
ahwayakchih:update-deps

Conversation

@ahwayakchih
Copy link
Copy Markdown
Contributor

@ahwayakchih ahwayakchih commented Feb 21, 2019

Hi,

This updates dependencies and refactors some code. It should fix #73, #67 and any other related issues.

  • replace github with official @octokit/rest
  • remove github-commit-stream and parse-link-header dependencies
  • replace nomnom with commander
  • refactor code to use new dependencies
  • update package-lock.json

- replace `github` with official `@octokit/rest`
- drop `github-commit-stream`
- replace `nomnom` with `commander`
thom4parisot pushed a commit to thom4parisot/crx that referenced this pull request Feb 28, 2019
This just updated dependencies to latest versions.

The only vulnerabilities left after this change are from `github-changes` module.
I prepared patch for that one too (lalitkapoor/github-changes#83), but project seems a bit... dead, so not sure if someone will update it anytime soon.
@lalitkapoor
Copy link
Copy Markdown
Owner

lalitkapoor commented Dec 30, 2020

Thank you so much for this! Your commits have been merged into #91 as I continued with clean up and upgraded some other dependencies as well. It resulted in me doing a major version upgrade because how auth works for github has changed and the old way is no longer supported.

@ahwayakchih ahwayakchih deleted the update-deps branch December 30, 2020 05:56
@304NotModified
Copy link
Copy Markdown
Contributor

@lalitkapoor

I guess these issues could be closed: #73, #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security issue with transitive dependency to [email protected]

3 participants