Skip to content

Aesthetic fixes#41

Merged
lalitkapoor merged 2 commits intolalitkapoor:masterfrom
nylen:aesthetic-fixes
Nov 6, 2014
Merged

Aesthetic fixes#41
lalitkapoor merged 2 commits intolalitkapoor:masterfrom
nylen:aesthetic-fixes

Conversation

@nylen
Copy link
Copy Markdown
Contributor

@nylen nylen commented Oct 24, 2014

A few minor aesthetic fixes that you should feel free to take anywhere between zero and all of:

  • Don't include time in version headings, because if you release more than one version a day you're doing it wrong
  • Sort commits and pulls in reverse chronological order, because that way recent changes appear at the top like recent versions do
  • Show progress when fetching commits in verbose mode, so it doesn't look like the program has hung

@nylen
Copy link
Copy Markdown
Contributor Author

nylen commented Oct 26, 2014

@lalitkapoor ping? we have someone asking for a new version of request, and I can use my local version of github-changes for now, but I'd like to have something like this incorporated for future versions.

@lalitkapoor
Copy link
Copy Markdown
Owner

  • don't include time in version headings - I'm going to use Add option to allow specifying the date format #46 to address this
  • commits & pulls in reverse chronological order - can we throw this on a flag, making your ordering the default (I like seeing the work done in the order that it was done between releases)
  • showing progress when fetching commits is looking good 👍

nylen added 2 commits November 4, 2014 20:53
Add a new `--reverse-changes` option to use the old order (showing the
work done in the order it was done between releases).
@nylen
Copy link
Copy Markdown
Contributor Author

nylen commented Nov 6, 2014

Done, thanks! I've got no problem with making the old order the default, if you like.

@lalitkapoor
Copy link
Copy Markdown
Owner

@nylen looks good. Thanks!

lalitkapoor added a commit that referenced this pull request Nov 6, 2014
@lalitkapoor lalitkapoor merged commit a67ec1e into lalitkapoor:master Nov 6, 2014
@lalitkapoor
Copy link
Copy Markdown
Owner

new version published to npm

nylen added a commit to nylen/request that referenced this pull request Nov 6, 2014
Now that lalitkapoor/github-changes#41 and lalitkapoor/github-changes#46
have been merged, generating the changelog should work for everyone.
sabaoongfx pushed a commit to sabaoongfx/request-modern that referenced this pull request Mar 10, 2026
Now that lalitkapoor/github-changes#41 and lalitkapoor/github-changes#46
have been merged, generating the changelog should work for everyone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants