Skip to content

show changes between two tags#30

Merged
lalitkapoor merged 3 commits intomasterfrom
30-show-changes-between-two-tags-only
Nov 26, 2014
Merged

show changes between two tags#30
lalitkapoor merged 3 commits intomasterfrom
30-show-changes-between-two-tags-only

Conversation

@lalitkapoor
Copy link
Copy Markdown
Owner

--between-tags and it would take 2 tags separated by 3 dots e.g. v0.0.3...v0.0.6.

Based on discussion in #29

Note: An improvement in the future would be to utilize the since option when getting commits

@lalitkapoor
Copy link
Copy Markdown
Owner Author

@RaviVaranasi can you clone and checkout branch 30-show-changes-between-two-tags-only and give it a spin. Hopefully this addresses what you need (as discussed in #29).

@lalitkapoor
Copy link
Copy Markdown
Owner Author

Also, if you want to hide the tag names you can use the newly added --hide-tag-names

@lalitkapoor lalitkapoor changed the title show changes between two tags only show changes between two tags Apr 18, 2014
@RaviVaranasi
Copy link
Copy Markdown

Do you know the github node module compare operation supports this (off
the top of your head)?

On Fri, Apr 18, 2014 at 5:16 PM, Lalit Kapoor [email protected]:

Also, if you want to hide the tag names you can use the newly added
--hide-tag-names


Reply to this email directly or view it on GitHubhttps://github.com//pull/30#issuecomment-40849349
.

@lalitkapoor
Copy link
Copy Markdown
Owner Author

@RaviVaranasi I did see that before, but I chose not to use that for two reasons:

  1. it returns patches for the files modified (this can be huge on bandwidth and can cause errors - see: https://developer.github.com/v3/repos/commits/#working-with-large-comparisons)
  2. If there are more than 250 commits then I'd have to revert to the commit API

@lalitkapoor
Copy link
Copy Markdown
Owner Author

@RaviVaranasi did you get a chance to give this a shot? I'm going to merge, tag, and publish this soon.

@RaviVaranasi
Copy link
Copy Markdown

Sorry Lalit,

I haven't had a chance on working on this. I have some initial ideas -

  1. Refactor index.js to extract the github api and formatting functionality.
  2. wanted to add some tests too.
  3. Also, it looks like it grabs all the tags. Unfortunately, we have a lot
    of tags in our project and got an error about call stack exceeded when
    trying to run it from command line. I was going change it to apply the
    filter in search filter.

I will try and work on it this weekend.

Ravi

On Thu, Apr 24, 2014 at 12:07 AM, Lalit Kapoor [email protected]:

@RaviVaranasi https://github.com/RaviVaranasi did you get a chance to
give this a shot? I'm going to merge, tag, and publish this soon.


Reply to this email directly or view it on GitHubhttps://github.com//pull/30#issuecomment-41243122
.

@FredKSchott
Copy link
Copy Markdown

+1 I'd love to use this feature :)

@lalitkapoor lalitkapoor self-assigned this Nov 19, 2014
lalitkapoor added a commit that referenced this pull request Nov 26, 2014
@lalitkapoor lalitkapoor merged commit e4910d5 into master Nov 26, 2014
@lalitkapoor lalitkapoor deleted the 30-show-changes-between-two-tags-only branch November 26, 2014 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants