Repository navigation
fix: preserve lambda bindings across projection pushdown - #2413
Merged
Merged
Conversation
|
Warning The baseline was not found. Spark 3.5.9 Test ReportCommit Information
Test Summary
Test DetailsError CountsPassed Tests Diff(empty) Failed Tests |
Spark 4.2.0 Test ReportCommit Information
Test Summary
Test DetailsError Counts(truncated) Passed Tests Diff(empty) Failed Tests(truncated) |
Ibis Test ReportCommit Information
Test Summary
Test DetailsError CountsPassed Tests Diff--- before.txt 2026-08-11 10:21:24.064244359 +0000
+++ after.txt 2026-08-11 10:21:24.256244405 +0000
@@ -533 +532,0 @@
-ibis/backends/tests/test_export.py::test_table_to_csv[pyspark]
@@ -758,0 +758 @@
+ibis/backends/tests/test_generic.py::test_uncorrelated_subquery[pyspark]Failed Tests |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #2413 +/- ##
==========================================
- Coverage 78.28% 78.27% -0.02%
==========================================
Files 959 960 +1
Lines 191687 191827 +140
==========================================
+ Hits 150065 150155 +90
- Misses 41622 41672 +50
*This pull request uses carry forward flags. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lonless9
changed the title
lonless9
requested review from
linhr and
shehabgamin
and removed request for
shehabgamin
August 13, 2026 06:41
Contributor
There was a problem hiding this comment.
Pull request overview
Adds lambda-safe projection pushdown to preserve physical bindings across schema rewrites.
Changes:
- Wraps DataFusion projection pushdown with temporary optimizer boundaries.
- Protects lambda projections and nested-loop join filters.
- Adds self-join and captured-column regression coverage.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/sail-physical-optimizer/src/projection_pushdown.rs |
Implements lambda-safe projection pushdown. |
crates/sail-physical-optimizer/src/lib.rs |
Registers the new optimizer rule. |
python/pysail/tests/spark/dataframe/test_higher_order_self_join.py |
Adds self-join and join-filter regressions. |
python/pysail/tests/spark/function/features/array/array_filter.feature |
Re-enables captured-column join coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
linhr
marked this pull request as ready for review
August 14, 2026 08:50
linhr
approved these changes
Aug 14, 2026
linhr
left a comment
linhr
left a comment
Contributor
There was a problem hiding this comment.
This workaround makes sense to me!
Would you like to create an issue with a minimum reproducible example (such as a unit test) so that the DataFusion community is aware of the root cause?
Gold Data ReportNotes
Commit Information
Summary
DetailsGold Data Metrics
|
Contributor
Author
|
@linhr Thanks for the review! I'll create an issue with an MRE upstream. |
Contributor
Author
|
Upstream issue created apache/datafusion#24372 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve physical lambda-variable bindings when DataFusion projection pushdown rewrites higher-order expressions across schema boundaries.
Temporary optimizer boundaries protect lambda-bearing projections from unsafe projection unification and protect lambda-bearing nested-loop join filters from join-filter extraction, while ordinary child projections remain eligible for optimization. All boundaries are removed before the optimized plan is returned. This addresses both higher-order self-join expressions and lambdas that capture columns across join sides.
Closes #2395