Add default task pools and method for configuring them#2
Merged
lachlansneff merged 3 commits intolachlansneff:bevy-tasksfrom Aug 28, 2020
Merged
Add default task pools and method for configuring them#2lachlansneff merged 3 commits intolachlansneff:bevy-tasksfrom
lachlansneff merged 3 commits intolachlansneff:bevy-tasksfrom
Conversation
Add IO, AsyncCompute and Compute TaskPools Move TaskPool setup from bevy_ecs to bevy_app ParallelExecutorOptions is essentially replaced by DefaultTaskPoolOptions
…ate module Add a prelude to bevy_tasks Update the version of bevy_tasks to match other crates
lachlansneff
approved these changes
Aug 27, 2020
Owner
lachlansneff
left a comment
lachlansneff
left a comment
There was a problem hiding this comment.
Yeah, this looks great. I left a few comments asking about decisions here or there, but otherwise, this is absolutely ready to merge.
Owner
|
This looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove generics from TaskPool newtypes and some of the task API
Add IO, AsyncCompute and Compute TaskPools
Move TaskPool setup from bevy_ecs to bevy_app
ParallelExecutorOptions is essentially replaced by DefaultTaskPoolOptions