Codecov Report

Merging #1880 (f27677a) into master (2acb24a) will increase coverage by 0.75%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##           master    #1880      +/-   ##
==========================================
+ Coverage   90.21%   90.97%   +0.75%     
==========================================
  Files          31       32       +1     
  Lines        2770     2791      +21     
==========================================
+ Hits         2499     2539      +40     
+ Misses        173      161      -12     
+ Partials       98       91       -7     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2acb24a...f27677a. Read the comment docs.

This will go in next minor v4.4 release.

@hoshsadiq Nice work! Could you also add a PR in github.com/labstack/echox to update the docs. I'd love to see an example using Jsoniter there.

This PR is currently about JSON encoding only. Should we consider decoding JSON too?
Especially when dealing with larger POSTS with JSON body that might be of interest for the binder.

Will raise the PR in echox soon.

I was thinking about the decoder, I just couldn't think where it would be needed. Not sure why. But now it makes sense. I'll update the PR soon.

I've just pushed a new commit that also adds the decoder. Wasn't quite sure what to name the interface, so if you have a better name for it, feel free to suggest!

I've just pushed a new commit that also adds the decoder. Wasn't quite sure what to name the interface, so if you have a better name for it, feel free to suggest!

I'd like to take the chance to discuss on naming of the interface, as the name should not change anytime soon after that (and will stick probably with v5 too). I personally like JSONCodec as it is pretty descriptive on that the interface is about.

Some other suggestions:

• JSONCoder ... more Go-like
• JSONSerializer ... descirbing the actual purpose of serialization
• JSONHandler ... pretty generic term

Other suggestions welcome, your feedback even more.

Personally I like JSONHandler and JSONSerializer (in that order). If there is no one other suggestions in the next few days, I'll change it to be JSONHandler.

In my case I prefer an explicit name, even if it is longer, like io.ReadWriteCloser because it is self explanatory. So, for me, I prefer JSONEncodeDecoder

In my case I prefer an explicit name, even if it is longer, like io.ReadWriteCloser because it is self explanatory. So, for me, I prefer JSONEncodeDecoder

That would lead to JSONWriter and JSONReader being to separate interfaces with a JSONReadWriter combining them.
But something like JSONSerializer oder JSONCoder does also describe the intended behaviour (which is the point of interfaces for me).

(That is no real objection, more a note of slight distaste for too long interface names)

ping, I vote for JSONSerializer and lets get this PR merged :)

I change my vote also to JSONSerializer, lets merge! ;-)
@hoshsadiq Please go ahead an rename. Thanks!

well well well. I was about to rename it myself and push changes but I started to look at that interface and JSONSerializer does not make sense with those method names. For encode and decode methods JSONCoder makes more sense.

	JSONCoder interface {
		Encode(c Context, i interface{}, indent string) error
		Decode(c Context, i interface{}) error
	}

Sorry, haven't had a chance to do this. If it becomes JSONSerializer, the methods would be Serialize and Deserialize.

Makes sense 👍 . @hoshsadiq you want to do renaming part yourself or I'll do it - that PR is already open at my IDE.

If you've got time feel free to do it, if not, I'll probably get to it on Sunday.

done. I'll merge it and in couple of days prepare changelog and release in v4.4.0