psbt: Require ECDSA signatures to be validly encoded

achow101 · achow101 · commit 5a5d26d6123e · 2025-05-14T14:00:23.000-07:00
Needed for later validation of sighash types.
diff --git a/src/psbt.h b/src/psbt.h
@@ -520,6 +520,11 @@ struct PSBTInput
                     std::vector<unsigned char> sig;
                     s >> sig;
 
+                    // Check that the signature is validly encoded
+                    if (sig.empty() || !CheckSignatureEncoding(sig, SCRIPT_VERIFY_DERSIG | SCRIPT_VERIFY_STRICTENC, nullptr)) {
+                        throw std::ios_base::failure("Signature is not a valid encoding");
+                    }
+
                     // Add to list
                     partial_sigs.emplace(pubkey.GetID(), SigPair(pubkey, std::move(sig)));
                     break;
