Stats() shouldn't assume s.container is non-nil

Kazuyoshi Kato · Kazuyoshi Kato · commit 49a54e23cb2d · 2022-10-12T22:11:49.000Z
Like other exported methods, Stats() shouldn't assume s.container is non-nil. Fixes containerd#7468. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
diff --git a/runtime/v2/runc/v1/service.go b/runtime/v2/runc/v1/service.go
@@ -596,7 +596,11 @@ func (s *service) Shutdown(ctx context.Context, r *taskAPI.ShutdownRequest) (*pt
 }
 
 func (s *service) Stats(ctx context.Context, r *taskAPI.StatsRequest) (*taskAPI.StatsResponse, error) {
-	cgx := s.container.Cgroup()
+	container, err := s.getContainer()
+	if err != nil {
+		return nil, err
+	}
+	cgx := container.Cgroup()
 	if cgx == nil {
 		return nil, errdefs.ToGRPCf(errdefs.ErrNotFound, "cgroup does not exist")
 	}

Original file line number	Diff line number	Diff line change
`@@ -596,7 +596,11 @@ func (s service) Shutdown(ctx context.Context, r taskAPI.ShutdownRequest) (*pt`
`596`	`596`	`}`
`597`	`597`
`598`	`598`	`func (s service) Stats(ctx context.Context, r taskAPI.StatsRequest) (*taskAPI.StatsResponse, error) {`
`599`		`- cgx := s.container.Cgroup()`
	`599`	`+ container, err := s.getContainer()`
	`600`	`+ if err != nil {`
	`601`	`+ return nil, err`
	`602`	`+ }`
	`603`	`+ cgx := container.Cgroup()`
`600`	`604`	`if cgx == nil {`
`601`	`605`	`return nil, errdefs.ToGRPCf(errdefs.ErrNotFound, "cgroup does not exist")`
`602`	`606`	`}`