fix: add ModulePath() to TestDeps for Go 1.26 compatibility by henrysachs · Pull Request #2646 · kyverno/chainsaw

henrysachs · 2026-02-27T12:18:33Z

Description

chainsaw fails to compile with Go 1.26 because testing.testDeps gained a new required method ModulePath() string in Go 1.26.

Error

github.com/kyverno/chainsaw/pkg/runner/internal.TestDeps does not implement
testing.testDeps (missing method ModulePath)

Root cause

pkg/runner/internal/test_deps.go implements the testing.testDeps interface but is missing ModulePath() string added in Go 1.26.

Fix

Added the missing method to `TestDeps`:

func (*TestDeps) ModulePath() string {
    return ""
}

Bumped go.mod to go 1.26.0.

Fixes #2645

Signed-off-by: Henry Sachs <[email protected]>

PodLogs in Finally/Catch invokes kubectl as subprocess; without a real cluster it exits non-zero, causing fail() to be called. expectedFail was incorrectly set to false (zero value). Corrected to true to match actual semantics. Signed-off-by: Henry Sachs <[email protected]>

henrysachs · 2026-02-27T12:52:18Z

Question for reviewers regarding the test fix:

The pre-existing test TestStepProcessor_Run/try,_catch_and_finally_operation_with_apply_handler was already failing on main (confirmed with Go 1.25 — the test fails, the compile error just masked it). But maybe my local setup ist just wrong so help is appreciated!

Happy to adjust the fix based on your guidance.

henrysachs · 2026-02-27T13:01:55Z

@eddycharly if you would be able to take a look that would be highly appreciated

henrysachs · 2026-03-03T07:43:00Z

sorry for pinging but @shubham-cmyk maybe you can help me get this through?

Avoid the gosec temp file path warning, update Trivy to a working action release, and keep the runner unit test independent from kubectl side effects. Signed-off-by: Henry Sachs <[email protected]>

Keep the original catch and finally pod log coverage in place even though the unit test still fails locally without the previous expectation change. Signed-off-by: Henry Sachs <[email protected]>

henrysachs · 2026-03-11T09:12:29Z

Local repro is green now: kind-backed make tests and golangci-lint both pass on the branch. The only remaining blocker should be the missing milestone on the PR. Could you @eddycharly or @shubham-cmyk please approve the workflows and set a milestone to have the CI turn green? :)

shubham-cmyk · 2026-03-11T09:49:12Z

@henrysachs the code QL is failing please check

Move CodeQL scanning to trivy-action v0.35.0 so the workflow uses the newer Trivy release instead of the broken v0.69.1 default. Signed-off-by: Henry Sachs <[email protected]>

henrysachs · 2026-03-11T10:00:17Z

@shubham-cmyk i hope that a action bump fixes it. I think this is related to the trivy issues: https://github.com/aquasecurity/trivy/discussions/10265

codecov · 2026-03-11T10:14:51Z

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.00%. Comparing base (f2bc418) to head (3c16078).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/loaders/resource/load.go	88.88%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2646      +/-   ##
==========================================
+ Coverage   66.95%   67.00%   +0.05%     
==========================================
  Files         149      149              
  Lines        5698     5707       +9     
==========================================
+ Hits         3815     3824       +9     
  Misses       1623     1623              
  Partials      260      260

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Cover the new ModulePath shim and exercise LoadFromURI through a local HTTP server so patch coverage reflects the CI fix paths. Signed-off-by: Henry Sachs <[email protected]>

henrysachs · 2026-03-11T10:29:11Z

@shubham-cmyk i made fixes for codecov. Atleast i hope to fix the coverage 😅

Extract the downloaded file read path behind a tiny read-seeker helper so seek and read errors can be covered without weakening the gosec-safe handle-based flow. Signed-off-by: Henry Sachs <[email protected]>

henrysachs · 2026-03-11T14:56:08Z

@shubham-cmyk i had to do this via the interface to adress the gosec finding and make it testable for codecov, so could you approve again?

shubham-cmyk · 2026-03-11T16:22:35Z

@shubham-cmyk i had to do this via the interface to adress the gosec finding and make it testable for codecov, so could you approve again?

Done

henrysachs · 2026-03-11T19:02:51Z

@shubham-cmyk so all checks passed, did you have some time to have a look on the changes?

shubham-cmyk · 2026-03-11T19:31:48Z

@henrysachs just update this we are ready to go

Co-authored-by: Shubham Gupta <[email protected]> Signed-off-by: Henry Sachs <[email protected]>

henrysachs · 2026-03-11T19:33:42Z

@shubham-cmyk there you go, thanks for the review!

henrysachs · 2026-03-12T08:08:57Z

@shubham-cmyk I know I'm really a bit pushy here, but could you also please publish a release from this?

shubham-cmyk · 2026-03-13T20:54:50Z

@henrysachs i have pinged @eddycharly for the release

henrysachs · 2026-03-17T07:39:06Z

@eddycharly could you please have a look into this?

fix: add ModulePath() to TestDeps for Go 1.26 compatibility

2de3030

Signed-off-by: Henry Sachs <[email protected]>

henrysachs requested a review from a team as a code owner February 27, 2026 12:18

henrysachs added 2 commits February 27, 2026 13:27

chore: bump go version to 1.26

97fc897

Signed-off-by: Henry Sachs <[email protected]>

henrysachs added 2 commits March 11, 2026 09:21

fix: stabilize go 1.26 CI

63a7a89

Avoid the gosec temp file path warning, update Trivy to a working action release, and keep the runner unit test independent from kubectl side effects. Signed-off-by: Henry Sachs <[email protected]>

revert: restore pod logs runner test

146c242

Keep the original catch and finally pod log coverage in place even though the unit test still fails locally without the previous expectation change. Signed-off-by: Henry Sachs <[email protected]>

shubham-cmyk added this to the v0.2.15 milestone Mar 11, 2026

fix(ci): bump trivy action

febe94e

Move CodeQL scanning to trivy-action v0.35.0 so the workflow uses the newer Trivy release instead of the broken v0.69.1 default. Signed-off-by: Henry Sachs <[email protected]>

test: cover go 1.26 CI fixes

7043f73

Cover the new ModulePath shim and exercise LoadFromURI through a local HTTP server so patch coverage reflects the CI fix paths. Signed-off-by: Henry Sachs <[email protected]>

test: cover temp file read branches

766dad7

Extract the downloaded file read path behind a tiny read-seeker helper so seek and read errors can be covered without weakening the gosec-safe handle-based flow. Signed-off-by: Henry Sachs <[email protected]>

shubham-cmyk requested changes Mar 11, 2026

View reviewed changes

Comment thread pkg/loaders/resource/load.go Outdated

Comment thread pkg/loaders/resource/load.go Outdated

fix: Apply suggestions from code review

3c16078

Co-authored-by: Shubham Gupta <[email protected]> Signed-off-by: Henry Sachs <[email protected]>

henrysachs requested a review from shubham-cmyk March 11, 2026 20:06

shubham-cmyk approved these changes Mar 11, 2026

View reviewed changes

shubham-cmyk merged commit 5f2001f into kyverno:main Mar 11, 2026
15 checks passed

henrysachs deleted the fix/go-1.26-testdeps-module-path branch March 13, 2026 10:32

xdu31 mentioned this pull request Mar 17, 2026

feat(validator): Replace chainsaw binary invocation with Go library runner NVIDIA/aicr#419

Closed

5 tasks

lockwobr mentioned this pull request Apr 21, 2026

docs: add ADR for deployment validation NVIDIA/aicr#630

Closed

25 tasks

Ayush-Patel-56 mentioned this pull request Apr 22, 2026

[Bug] go install fails on .TestDeps does not implement "testing".testDeps #2684

Closed

1 task

Uh oh!

Conversation

henrysachs commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Error

Root cause

Fix

Uh oh!

henrysachs commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

henrysachs commented Feb 27, 2026

Uh oh!

henrysachs commented Mar 3, 2026

Uh oh!

henrysachs commented Mar 11, 2026

Uh oh!

shubham-cmyk commented Mar 11, 2026

Uh oh!

henrysachs commented Mar 11, 2026

Uh oh!

codecov Bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

henrysachs commented Mar 11, 2026

Uh oh!

henrysachs commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shubham-cmyk commented Mar 11, 2026

Uh oh!

henrysachs commented Mar 11, 2026

Uh oh!

Uh oh!

Uh oh!

shubham-cmyk commented Mar 11, 2026

Uh oh!

henrysachs commented Mar 11, 2026

Uh oh!

Uh oh!

henrysachs commented Mar 12, 2026

Uh oh!

shubham-cmyk commented Mar 13, 2026

Uh oh!

henrysachs commented Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

henrysachs commented Feb 27, 2026 •

edited

Loading

henrysachs commented Feb 27, 2026 •

edited

Loading

codecov Bot commented Mar 11, 2026 •

edited

Loading

henrysachs commented Mar 11, 2026 •

edited

Loading