chore(docs): add required try block#2186
Merged
Merged
Conversation
eddycharly
approved these changes
Dec 5, 2024
Member
|
Thanks for catching this and opening the fix PR! |
eddycharly
enabled auto-merge (squash)
December 5, 2024 11:21
Member
|
@noeleont can you sign-off your commits please ? |
Signed-off-by: Noe Thalheim <[email protected]>
auto-merge was automatically disabled
December 5, 2024 14:41
Head branch was pushed to by a user without write access
noeleont
force-pushed
the
chore/fix-docs
branch
from
December 5, 2024 14:41
5e85b58 to
5715744
Compare
eddycharly
enabled auto-merge (squash)
December 5, 2024 14:43
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2186 +/- ##
==========================================
+ Coverage 67.12% 67.17% +0.04%
==========================================
Files 138 138
Lines 6644 6650 +6
==========================================
+ Hits 4460 4467 +7
+ Misses 1859 1858 -1
Partials 325 325 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
I went trough the getting started and noticed a missing
tryblock.Related issue
Proposed Changes
Checklist
Further Comments