update for twitter's new weighted char counting and 280 char limit #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you elaborate on using inclusive matches for checking that a codepoint is within the range? I don’t remember seeing that on the documentation. |
|
From a quick test pasting strange symbols into Twitter ends-inclusive appears to be correct. |
background: kylewm#8 https://developer.twitter.com/en/docs/developer-utilities/twitter-text https://twittercommunity.com/t/updating-the-character-limit-and-the-twitter-text-library/96425 https://blog.twitter.com/official/en_us/topics/product/2017/tweetingmadeeasier.html the new algorithm is more complicated than before, but not too bad. test cases are updated in kylewm/brevity-testcases#2. cc @Zegnat @sknebel @aaronpk
|
Thank you for doing this! |
|
welcome! and damn, i just noticed the python 3 CI failures. easy fix, i'll send another PR. (and also update changelog etc.) |
snarfed
added a commit
to snarfed/brevity
that referenced
this pull request
Nov 20, 2017
`weight / WEIGHTS['scale']` with int operands evaluates to int in python 2, but float in python 3, so cast `str_length` to int explicitly.
snarfed
added a commit
to snarfed/bridgy
that referenced
this pull request
Nov 21, 2017
background: kylewm/brevity#8, kylewm/brevity#9 https://developer.twitter.com/en/docs/developer-utilities/twitter-text https://twittercommunity.com/t/updating-the-character-limit-and-the-twitter-text-library/96425 https://blog.twitter.com/official/en_us/topics/product/2017/tweetingmadeeasier.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background:
#8
https://developer.twitter.com/en/docs/developer-utilities/twitter-text
https://twittercommunity.com/t/updating-the-character-limit-and-the-twitter-text-library/96425
https://blog.twitter.com/official/en_us/topics/product/2017/tweetingmadeeasier.html
the new algorithm is more complicated than before, but not too bad.
test cases are updated in kylewm/brevity-testcases#2.
cc @Zegnat @sknebel @aaronpk