Skip to content

down right back to right up back conversion in llff.py #58

@hturki

Description

@hturki

Describe the bug
I'm trying to make sure that I understand the purpose of https://github.com/kwea123/nerf_pl/blob/dev/datasets/llff.py#L198. In particular, we're changing the coordinate system of the rotation matrix R but not of the translation vector, which remains in "down right back" coordinates - is that intentional?

Also bmild/nerf#34 suggests that this is mainly intended for forward facing scenes where we're using NDC, but if I'm interpreting the code correctly this transformation still happens for 360 scenes. Is that intentional and desired behavior?

Which branch you use
dev

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions