Conversation
w1am
force-pushed
the
w1am/dev-863-node-client-add-support-for-pinnedbycorrelation-strategy
branch
8 times, most recently
from
0752409 to
e18b38e
Compare
* Only support PinnedByCorrelation on create operation only * Support for updating a persistent subscription consumer strategy will not be allowed in the next major release. Users are recommended to delete and re create their persistent subscription.
w1am
force-pushed
the
w1am/dev-863-node-client-add-support-for-pinnedbycorrelation-strategy
branch
from
e18b38e to
8e5edc8
Compare
w1am
deleted the
w1am/dev-863-node-client-add-support-for-pinnedbycorrelation-strategy
branch
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🚨 @w1am Failed to create cherry Pick PR due to error:
RequestError [HttpError]: Merge conflict
at /home/runner/work/_actions/kurrent-io/Automations/master/cherry-pick-pr-for-label/node_modules/@octokit/request/dist-node/index.js:66:23
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
status: '409',
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
'content-length': '127',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Wed, 20 Aug 2025 12:25:26 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'github.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-github-permissions': 'contents=write',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-api-version-selected': '2022-11-28',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': 'A412:1804C0:408D1FA:423482B:68A5BEB6',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4844',
'x-ratelimit-reset': '1755695005',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '156',
'x-xss-protection': '0'
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/kurrent-io/KurrentDB-Client-NodeJS/merges',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'octokit-core.js/3.3.2 Node.js/20.19.4 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"base":"cherry-pick-cherry-pick/434/w1am/dev-863-node-client-add-support-for-pinnedbycorrelation-strategy-release/v1.0-5e37f463-ad37-4ad8-9791-0f28a778cb6c","commit_message":"Merge 8e5edc813d51bbbb880b39e806335eca5744b186 into cherry-pick-cherry-pick/434/w1am/dev-863-node-client-add-support-for-pinnedbycorrelation-strategy-release/v1.0-5e37f463-ad37-4ad8-9791-0f28a778cb6c [skip ci]\\n\\n\\nskip-checks: true\\n","head":"8e5edc813d51bbbb880b39e806335eca5744b186"}',
request: { agent: [Agent], hook: [Function: bound bound register] }
},
documentation_url: 'https://docs.github.com/rest/branches/branches#merge-a-branch'
}
w1am
added a commit
that referenced
this pull request
Oct 20, 2025
* Only support PinnedByCorrelation on create operation only * Support for updating a persistent subscription consumer strategy will not be allowed in the next major release. Users are recommended to delete and re create their persistent subscription.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PinnedByCorrelation name strategy was added in server version 21.10.1, but clients never supported it because they were unable to update it after creation. Starting with the next major release, we will no longer provide the ability to update a consumer strategy when updating a persistent subscription. Users should instead create a new persistent subscription.