Repository navigation
Conversation
The original sqllogictest reproducer collapsed to a single sort (the group key was primary in both orderings), so it passed with and without the LimitPushdown fix. Replace it with an aggregate query using anti-correlated inner/outer sort keys, which exercises the offset-leak path and drops a grouped row when the fix is absent. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Author
|
Incorporated in apache@bc2e5d7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to apache#22525 — replaces the
limit.sltregression test with one that actually fails without the fix and passes with it.