Skip to content

Commit 5471320

Browse files
committed
test: drop the fan-in cap from the shared-pool replay tests
The unit tests cover the spill and replay lifecycle in a shared pool. Case G in aggregate_memory_spill.slt covers the merge fan-in regression for apache#25423, so the tests do not need the cap. Say so in the helper's doc comment.
1 parent ec090ed commit 5471320

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎datafusion/physical-plan/src/aggregates/hash_stream.rs‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1652,6 +1652,11 @@ mod tests {
16521652

16531653
/// Partition 0 spills and replays while partitions 1..3 keep their
16541654
/// aggregate state in the same greedy pool.
1655+
///
1656+
/// These cases cover the spill and replay lifecycle in a shared pool:
1657+
/// results, spill metrics, and memory release. Case G in
1658+
/// `aggregate_memory_spill.slt` covers the merge fan-in regression for
1659+
/// issue #25423.
16551660
async fn run_shared_pool_case(
16561661
input_batches: i64,
16571662
limit: usize,
@@ -1715,7 +1720,6 @@ mod tests {
17151720
.with_session_config(SessionConfig::new().with_batch_size(128))
17161721
.with_runtime(
17171722
RuntimeEnvBuilder::new()
1718-
.with_max_spill_merge_fan_in(2)
17191723
.with_memory_pool(Arc::clone(&pool))
17201724
.build_arc()?,
17211725
),

0 commit comments

Comments
 (0)