This repository was archived by the owner on Jan 19, 2026. It is now read-only.
fix(ci): add second cosign signature for compatibility#1314
Merged
flavio merged 1 commit intokubewarden:mainfrom Oct 28, 2025
Merged
fix(ci): add second cosign signature for compatibility#1314flavio merged 1 commit intokubewarden:mainfrom
flavio merged 1 commit intokubewarden:mainfrom
Conversation
github-project-automation
bot
moved this to Pending review
in Kubewarden Admission Controller
viccuad
reviewed
Oct 27, 2025
| # Sign blob with cosign v3 signature format for compatibility | ||
| cosign sign-blob --yes --new-bundle-format=true --use-signing-config=true \ | ||
| --bundle policy-server-attestation-${{ matrix.arch }}-provenance.intoto.jsonl.bundle.sigstore \ | ||
| policy-server-attestation-${{ matrix.arch }}-provenance.intoto.jsonl |
Member
There was a problem hiding this comment.
I think:
- We are saving the cosign-v2 signature into a
policy-server-attestation-${{ matrix.arch }}-provenance.intoto.jsonl. We maybe should save it to a-provenance.cosign-v2.intoto.jsonlor similar. - We are overwriting that file with the cosign-v3 signature.
- If we indeed have 2 signatures, we should add them as artifacts at the end of release.yml
Member
Author
There was a problem hiding this comment.
Good point. I've updated all the PR adding this double signature removing the cosign v2 signatures for the blobs signed (attestation files and binaries)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1314 +/- ##
=======================================
Coverage 40.76% 40.76%
=======================================
Files 16 16
Lines 1207 1207
=======================================
Hits 492 492
Misses 715 715
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In order to allow old cosign version and other verification tools to verify the signature it's necessary to add a second signature using the old format. The default format before cosign v3 changed the default signature bundle. Signed-off-by: José Guilherme Vanz <[email protected]>
flavio
approved these changes
Oct 28, 2025
Member
flavio
left a comment
flavio
left a comment
There was a problem hiding this comment.
I like this PR. I like the strategy of signing with v2 and v3 format inside of the OCI registry, but sign only with v3 the blobs that are going to be made available as assets of the GitHub Release
github-project-automation
bot
moved this from Pending review
to Done
in Kubewarden Admission Controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to allow old cosign version and other verification tools to verify the signature it's necessary to add a second signature using the old format. The default format before cosign v3 changed the default signature bundle.