This repository was archived by the owner on Jan 19, 2026. It is now read-only.
fix: graceful handling of failures during sigstore init#1302
Merged
flavio merged 3 commits intokubewarden:mainfrom Oct 13, 2025
Merged
Conversation
Do not crash when Sigstore initialization fails. Fixes kubewarden#1300 Signed-off-by: Flavio Castelli <[email protected]>
We need to tag a patch release of Policy Server, but one of our tests fails because of a Sigstore issue. Temporarily skip the broken test to allow a quick patch release. Signed-off-by: Flavio Castelli <[email protected]>
Prepare the 1.29.1 patch release that addresses issue kubewarden#1300 Signed-off-by: Flavio Castelli <[email protected]>
github-project-automation
bot
moved this to Pending review
in Kubewarden Admission Controller
flavio
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1302 +/- ##
==========================================
- Coverage 51.60% 50.55% -1.06%
==========================================
Files 17 17
Lines 1087 1090 +3
==========================================
- Hits 561 551 -10
- Misses 526 539 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
olblak
approved these changes
Oct 13, 2025
github-project-automation
bot
moved this from Pending review
to Done
in Kubewarden Admission Controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements graceful handling of Sigstore init failures. Policy Server will no longer panic when something is wrong with Sigstore's TUF repository, it will simply inform the user that verification capabilities are not going to work at thei full potential.
This is required to fix issue #1300.
Once merged, we can tag a patch release of Policy Server.
We will investigate the TUF issue without leaving our users with a broken system.