This repository was archived by the owner on Jan 19, 2026. It is now read-only.
ci!: Update signing for sigstore v3#1401
Merged
flavio merged 1 commit intokubewarden:mainfrom Oct 22, 2025
Merged
Conversation
github-project-automation
bot
moved this to Pending review
in Kubewarden Admission Controller
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1401 +/- ##
==========================================
- Coverage 86.74% 86.67% -0.07%
==========================================
Files 34 34
Lines 4495 4495
==========================================
- Hits 3899 3896 -3
- Misses 596 599 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
With the move to sigstore v3, instead of saving the cert and sig on each signing operation, we save an `X.bundle.sigstore`. Signed-off-by: Víctor Cuadrado Juan <[email protected]>
viccuad
force-pushed
the
ci/sigstore-v3
branch
from
ebb505e to
7d7a040
Compare
Member
Author
|
Fixed a Windows error and repushed. |
flavio
approved these changes
Oct 22, 2025
github-project-automation
bot
moved this from Pending review
to Done
in Kubewarden Admission Controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the move to sigstore v3, instead of saving the cert and sig on each signing operation, we save an
X.bundle.sigstore.Test
Testing on my fork:
https://github.com/viccuad/kwctl/actions/runs/18715036597https://github.com/viccuad/kwctl/actions/runs/18716654959
Additional Information
Tradeoff
Potential improvement