Skip to content
This repository was archived by the owner on Jan 19, 2026. It is now read-only.

Backport graceful handling of failures during sigstore init to 1.29#1395

Merged
flavio merged 3 commits intokubewarden:maintenance/1.29from
flavio:backport-graceful-handling-of-failures-during-sigstore-init-to-1.29
Oct 13, 2025
Merged

Backport graceful handling of failures during sigstore init to 1.29#1395
flavio merged 3 commits intokubewarden:maintenance/1.29from
flavio:backport-graceful-handling-of-failures-during-sigstore-init-to-1.29

Conversation

@flavio
Copy link
Copy Markdown
Member

@flavio flavio commented Oct 13, 2025

Backport of #1394 to 1.29.

We cannot do that on main since we've already tagged 1.30.0-beta1.

Do not panic when Sigstore cannot be initialized, unless the user wants
to verify the integrity of the policy he's about to run.

Signed-off-by: Flavio Castelli <[email protected]>
Do not run the e2e tests that are broken by the sigstore-rs issue. We
need to cut a patch release of kwctl ASAP.

Signed-off-by: Flavio Castelli <[email protected]>
Backport the fixes required to handle failures when Sigstore cannot be
initialized.

Signed-off-by: Flavio Castelli <[email protected]>
@flavio flavio merged commit 79510d1 into kubewarden:maintenance/1.29 Oct 13, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Pending review to Done in Kubewarden Admission Controller Oct 13, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.88%. Comparing base (791f516) to head (5070d6e).
⚠️ Report is 4 commits behind head on maintenance/1.29.

Files with missing lines Patch % Lines
src/config/pull_and_run.rs 36.36% 14 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           maintenance/1.29    #1395      +/-   ##
====================================================
- Coverage             87.50%   82.88%   -4.63%     
====================================================
  Files                    34       34              
  Lines                  4955     4967      +12     
====================================================
- Hits                   4336     4117     -219     
- Misses                  619      850     +231     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flavio flavio deleted the backport-graceful-handling-of-failures-during-sigstore-init-to-1.29 branch October 13, 2025 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants