Skip to content
This repository was archived by the owner on Jan 19, 2026. It is now read-only.

fix: graceful handling of failures while initializing Sigstore#1394

Merged
flavio merged 3 commits intokubewarden:mainfrom
flavio:graceful-handling-of-failures-during-sigstore-init
Oct 13, 2025
Merged

fix: graceful handling of failures while initializing Sigstore#1394
flavio merged 3 commits intokubewarden:mainfrom
flavio:graceful-handling-of-failures-during-sigstore-init

Conversation

@flavio
Copy link
Copy Markdown
Member

@flavio flavio commented Oct 13, 2025

Do not panic when Sigstore cannot be initialized, unless the user wants to verify the integrity of the policy he's about to run.

Do not panic when Sigstore cannot be initialized, unless the user wants
to verify the integrity of the policy he's about to run.

Signed-off-by: Flavio Castelli <[email protected]>
Do not run the e2e tests that are broken by the sigstore-rs issue. We
need to cut a patch release of kwctl ASAP.

Signed-off-by: Flavio Castelli <[email protected]>
Prepare a new beta release of 1.30.0

Signed-off-by: Flavio Castelli <[email protected]>
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.45%. Comparing base (8b2ad2b) to head (b4c3d03).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/config/pull_and_run.rs 36.36% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1394      +/-   ##
==========================================
- Coverage   87.18%   82.45%   -4.73%     
==========================================
  Files          34       34              
  Lines        4565     4577      +12     
==========================================
- Hits         3980     3774     -206     
- Misses        585      803     +218     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flavio flavio merged commit 52eb510 into kubewarden:main Oct 13, 2025
15 of 17 checks passed
@github-project-automation github-project-automation bot moved this from Pending review to Done in Kubewarden Admission Controller Oct 13, 2025
@flavio flavio deleted the graceful-handling-of-failures-during-sigstore-init branch October 13, 2025 09:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

Development

Successfully merging this pull request may close these issues.

2 participants