This repository was archived by the owner on Jan 19, 2026. It is now read-only.
feat!: Implement vap scaffold vap for paramKind, paramRef, failurePolicy#1390
Merged
viccuad merged 5 commits intokubewarden:mainfrom Oct 7, 2025
Merged
feat!: Implement vap scaffold vap for paramKind, paramRef, failurePolicy#1390viccuad merged 5 commits intokubewarden:mainfrom
vap scaffold vap for paramKind, paramRef, failurePolicy#1390viccuad merged 5 commits intokubewarden:mainfrom
Conversation
github-project-automation
bot
moved this to Pending review
in Kubewarden Admission Controller
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1390 +/- ##
==========================================
- Coverage 87.50% 87.18% -0.33%
==========================================
Files 34 34
Lines 4955 4565 -390
==========================================
- Hits 4336 3980 -356
+ Misses 619 585 -34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
viccuad
force-pushed
the
feat/vap-params
branch
from
549ec33 to
f7398bd
Compare
jvanz
suggested changes
Oct 6, 2025
viccuad
moved this from Pending review
to In Progress
in Kubewarden Admission Controller
flavio
suggested changes
Oct 7, 2025
Member
flavio
left a comment
flavio
left a comment
There was a problem hiding this comment.
LGTM, I left a minor suggestion
Member
|
I think we should cover the migration of these fields of the VAP policy too
|
viccuad
force-pushed
the
feat/vap-params
branch
from
8048c49 to
dd24edd
Compare
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
On the cel-policy from Kubewarden: - `spec.failurePolicy`: For Webhook behaviour - `spec.settings.failurePolicy`: For CEL behaviour Signed-off-by: Víctor Cuadrado Juan <[email protected]>
viccuad
force-pushed
the
feat/vap-params
branch
from
dd24edd to
bc10bec
Compare
flavio
reviewed
Oct 7, 2025
Member
Author
This is already included when populating
Indeed. This is done in bc10bec. |
This is incredibly annoying, I have locally the same components as the CI: `stable-x86_64-unknown-linux-gnu unchanged - rustc 1.90.0 (1159e78c4 2025-09-14)` yet the CI fails on rustfmt. Signed-off-by: Víctor Cuadrado Juan <[email protected]>
viccuad
changed the title
vap scaffold vap for paramKind, paramRefvap scaffold vap for paramKind, paramRef, failurePolicy
flavio
approved these changes
Oct 7, 2025
viccuad
moved this from In Progress
to Pending review
in Kubewarden Admission Controller
jvanz
approved these changes
Oct 7, 2025
Member
jvanz
left a comment
jvanz
left a comment
There was a problem hiding this comment.
Besides my small suggestion, LGTM
Co-authored-by: José Guilherme Vanz <[email protected]> Signed-off-by: Víctor Cuadrado Juan <[email protected]>
github-project-automation
bot
moved this from Pending review
to Done
in Kubewarden Admission Controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of kubewarden/cel-policy#161
Test
Added unit test case.
Additional Information
Tradeoff
Potential improvement