This repository was archived by the owner on Jan 20, 2026. It is now read-only.
feat(params): enabling paramKind and paramRef to the policy#185
Merged
flavio merged 6 commits intokubewarden:mainfrom Oct 7, 2025
Merged
feat(params): enabling paramKind and paramRef to the policy#185flavio merged 6 commits intokubewarden:mainfrom
flavio merged 6 commits intokubewarden:mainfrom
Conversation
viccuad
reviewed
Sep 25, 2025
viccuad
reviewed
Sep 25, 2025
viccuad
reviewed
Sep 25, 2025
viccuad
reviewed
Sep 25, 2025
viccuad
reviewed
Sep 25, 2025
Member
|
Missing to review validate.go and validate_test.go, will get to it tomorrow. |
viccuad
reviewed
Sep 26, 2025
viccuad
reviewed
Sep 26, 2025
viccuad
reviewed
Sep 26, 2025
viccuad
reviewed
Sep 26, 2025
viccuad
reviewed
Sep 26, 2025
viccuad
reviewed
Sep 26, 2025
viccuad
reviewed
Sep 26, 2025
viccuad
reviewed
Sep 26, 2025
viccuad
reviewed
Sep 26, 2025
Member
viccuad
left a comment
viccuad
left a comment
There was a problem hiding this comment.
I think it would be valuable to put all the params new functions under validate/{params.go,params_test.go}.
flavio
reviewed
Sep 26, 2025
jvanz
force-pushed
the
params
branch
2 times, most recently
from
3f6d56b to
2b41289
Compare
jvanz
commented
Sep 26, 2025
jvanz
force-pushed
the
params
branch
2 times, most recently
from
1a6586d to
92bb8bd
Compare
viccuad
reviewed
Oct 2, 2025
viccuad
reviewed
Oct 2, 2025
| expression: "object.spec.replicas" | ||
| validations: | ||
| - expression: "variables.replicas <= 5" | ||
| - expression: "variables.replicas <= params.data.maxreplicas" |
Member
There was a problem hiding this comment.
I would include also the definition for the ConfigMap in this same YAML block to tie everything together. That way people don't need to know about VAPs.
Member
Author
There was a problem hiding this comment.
Sorry, I did not understand the request. Do you want to add a comment with an example of the params ConfigMap resource in the yaml block?
Member
There was a problem hiding this comment.
Yes, that was the idea.
I did that for kubewarden/docs#683 on the docs. I'm conflicted, as it just grows the example. What do you think about it?
Member
Author
There was a problem hiding this comment.
I think we can added. It's small number of line and give a better understanding of what's going on.
viccuad
reviewed
Oct 2, 2025
flavio
suggested changes
Oct 2, 2025
Member
flavio
left a comment
flavio
left a comment
There was a problem hiding this comment.
LGTM, I left some minor comments
Member
Author
viccuad
approved these changes
Oct 6, 2025
Member
There was a problem hiding this comment.
LGTM! 🚀
Reminder, we still need some changes to docs.kubewarden.io. Edit: opened kubewarden/docs#683.
viccuad
reviewed
Oct 7, 2025
flavio
approved these changes
Oct 7, 2025
viccuad
approved these changes
Oct 7, 2025
Adds new policy settings to allow users to define policy parameters. To address that, now the policy has new settings fields that work in the same way that Kubernetes ValidatingAdmissionPolicy works. Signed-off-by: José Guilherme Vanz <[email protected]>
Update linter version and fixes all the errors pointed by it. Signed-off-by: José Guilherme Vanz <[email protected]>
Moves the functions used to manipulate and fetch parameters to a dedicated file. And, refactor the evaluation functions to remove duplicate code to that iterate and run evaluations. Also fixes some review comments. Signed-off-by: José Guilherme Vanz <[email protected]>
Updates the e2e tests target to generate the metadata.yml file used to annonate the policy used in the e2e test run. Document this behaivour on CONTRIBUTING.md. Signed-off-by: José Guilherme Vanz <[email protected]>
Updates the evaluateValidation signature to return (ValidationResponse,error). Furthermore, fix a type and move more specific function down in the files. Signed-off-by: José Guilherme Vanz <[email protected]>
Updates the README example adding a ConfigMap definition to be used as resource parameter. Signed-off-by: José Guilherme Vanz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds new policy settings to allow users to define policy parameters. To address that, now the policy has new settings fields that work in the same way that Kubernetes ValidatingAdmissionPolicy works.
Fix #161
Test
make test e2e-test