Skip to content

docs: Name virtqemud as the daemon in virt-launcher - #19618

Merged
kubevirt-prow[bot] merged 2 commits into
kubevirt:mainfrom
fjvbn2003:docs-virtqemud
Oct 29, 2026
Merged

kubevirt-prow[bot] merged 2 commits into
kubevirt:mainfrom
fjvbn2003:docs-virtqemud

Conversation

@fjvbn2003

Copy link
Copy Markdown
Contributor

What this PR does

Before this PR:

docs/components.md describes a libvirtd instance in every VMI pod and has a libvirtd section, and
docs/architecture.md lists libvirtd among the cluster-wide KubeVirt components. Since #8619 (first released in
v0.59.0) virt-launcher starts virtqemud, the modular libvirt daemon for the QEMU driver, and the virt-launcher image
no longer contains libvirtd.

Process list of the compute container of a running VMI (quay.io/kubevirt/virt-launcher:v1.9.0):

/usr/bin/virt-launcher-monitor ...
/usr/bin/virt-launcher ...
/usr/sbin/virtqemud -f /var/run/libvirt/virtqemud.conf
/usr/sbin/virtlogd -f /etc/libvirt/virtlogd.conf
/usr/libexec/qemu-kvm -name guest=default_fedora-vm,...

/usr/sbin in that image has virtqemud and virtlogd, but no libvirtd. In the code, see
cmd/virt-launcher/virt-launcher.go ("Start virtqemud, virtlogd, and establish libvirt connection") and
StartVirtqemud in pkg/virt-launcher/virtwrap/util/libvirt_helper.go.

After this PR:

  • components.md: the flow and the virt-launcher section say virtqemud, and the libvirtd section becomes a
    virtqemud section that mentions virtlogd and that releases before v0.59 used libvirtd.
  • architecture.md: libvirtd is removed from the cluster-wide component list; the managed pods line says each VMI
    has a virt-launcher pod running virtqemud.

References

Why we need it and why it was done in this way

The following tradeoffs were made:

  • docs/vm-configuration.md also mentions libvirtd, but there it quotes libvirt's general privilege model, which is
    still accurate, so it is left as is.

The following alternatives were considered:

  • Writing "libvirt" everywhere instead of naming the daemon. The section is about the process that runs in the pod,
    and people debugging a launcher see virtqemud in ps, so the concrete name is more useful.

Links to places where the discussion took place: none

Special notes for your reviewer

Docs only.

Checklist

  • Design: A VEP was considered and is not required
  • PR: The PR description is expressive enough and will help future contributors
  • Code: Write code that humans can understand and Keep it simple
  • Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
  • Upgrade: Impact of this change on upgrade flows was considered and addressed if required
  • Testing: not applicable (docs only)
  • Documentation: A user-guide update was considered and is not required
  • Community: Announcement to kubevirt-dev was considered
  • AI Contributions: The PR abides by the KubeVirt AI Contribution Policy.

I used Claude (Anthropic) while reading the code and to draft the wording. I checked the process list on my own
cluster and reviewed every line. The commit carries an Assisted-by trailer.

Release note

NONE

Since v0.59 virt-launcher starts virtqemud, the modular libvirt
daemon for the QEMU driver, instead of the monolithic libvirtd. The
virt-launcher image no longer ships libvirtd at all, but
components.md and architecture.md still describe a libvirtd instance
in every VMI pod, and architecture.md lists it among the cluster-wide
components.

Describe virtqemud instead and note when it replaced libvirtd.

Assisted-by: Claude <[email protected]>
Signed-off-by: YoungjuKim <[email protected]>
@kubevirt-prow kubevirt-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 25, 2026
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kubevirt-prow kubevirt-prow Bot added the size/S label Oct 25, 2026
@kubevirt-prow

kubevirt-prow Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Hi @fjvbn2003. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Comment thread docs/architecture.md
The following diagram illustrates how the additional controllers and daemons
communicate with Kubernetes and where the additional types are stored:

![Architecture diagram](architecture.png "Architecture")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs updating

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch. The diagram still showed libvirtd in the per-VMI pod. I changed the label to virtqemud in architecture.svg and re-exported architecture.png from it at the same size.

The per-VMI pod in architecture.svg/png still showed libvirtd between
virt-launcher and qemu. Rename the box to virtqemud to match the text.

Only the label changed in the SVG. The PNG was re-exported from it at
the same size (3860x2252) and with the same export area as before.

Assisted-by: Claude <[email protected]>
Signed-off-by: YoungjuKim <[email protected]>

@jean-edouard jean-edouard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-prow

kubevirt-prow Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jean-edouard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-prow kubevirt-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2026
@ksimon1

ksimon1 commented Oct 29, 2026

Copy link
Copy Markdown
Member

/lgtm

@kubevirt-prow kubevirt-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2026
@kubevirt-commenter-bot

Copy link
Copy Markdown

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-k8s-1.36-windows2016
/test pull-kubevirt-e2e-kind-1.37-vgpu
/test pull-kubevirt-e2e-k8s-1.37-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.36-sig-network
/test pull-kubevirt-e2e-k8s-1.36-sig-storage
/test pull-kubevirt-e2e-k8s-1.36-sig-compute
/test pull-kubevirt-e2e-k8s-1.36-sig-operator
/test pull-kubevirt-e2e-k8s-1.37-sig-network
/test pull-kubevirt-e2e-kind-1.37-sev

@orelmisan orelmisan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @fjvbn2003!

@kubevirt-prow
kubevirt-prow Bot merged commit 02735c6 into kubevirt:main Oct 29, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants