Repository navigation
docs: Name virtqemud as the daemon in virt-launcher - #19618
Conversation
Since v0.59 virt-launcher starts virtqemud, the modular libvirt daemon for the QEMU driver, instead of the monolithic libvirtd. The virt-launcher image no longer ships libvirtd at all, but components.md and architecture.md still describe a libvirtd instance in every VMI pod, and architecture.md lists it among the cluster-wide components. Describe virtqemud instead and note when it replaced libvirtd. Assisted-by: Claude <[email protected]> Signed-off-by: YoungjuKim <[email protected]>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
|
Hi @fjvbn2003. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| The following diagram illustrates how the additional controllers and daemons | ||
| communicate with Kubernetes and where the additional types are stored: | ||
|
|
||
|  |
There was a problem hiding this comment.
Thanks, good catch. The diagram still showed libvirtd in the per-VMI pod. I changed the label to virtqemud in architecture.svg and re-exported architecture.png from it at the same size.
The per-VMI pod in architecture.svg/png still showed libvirtd between virt-launcher and qemu. Rename the box to virtqemud to match the text. Only the label changed in the SVG. The PNG was re-exported from it at the same size (3860x2252) and with the same export area as before. Assisted-by: Claude <[email protected]> Signed-off-by: YoungjuKim <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jean-edouard The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
Required labels detected, running phase 2 presubmits: |
orelmisan
left a comment
There was a problem hiding this comment.
Thank you for your contribution @fjvbn2003!
What this PR does
Before this PR:
docs/components.mddescribes alibvirtdinstance in every VMI pod and has alibvirtdsection, anddocs/architecture.mdlistslibvirtdamong the cluster-wide KubeVirt components. Since #8619 (first released inv0.59.0) virt-launcher starts
virtqemud, the modular libvirt daemon for the QEMU driver, and the virt-launcher imageno longer contains
libvirtd.Process list of the
computecontainer of a running VMI (quay.io/kubevirt/virt-launcher:v1.9.0):/usr/sbinin that image hasvirtqemudandvirtlogd, but nolibvirtd. In the code, seecmd/virt-launcher/virt-launcher.go("Start virtqemud, virtlogd, and establish libvirt connection") andStartVirtqemudinpkg/virt-launcher/virtwrap/util/libvirt_helper.go.After this PR:
components.md: the flow and the virt-launcher section sayvirtqemud, and thelibvirtdsection becomes avirtqemudsection that mentionsvirtlogdand that releases before v0.59 usedlibvirtd.architecture.md:libvirtdis removed from the cluster-wide component list; the managed pods line says each VMIhas a virt-launcher pod running virtqemud.
References
Why we need it and why it was done in this way
The following tradeoffs were made:
docs/vm-configuration.mdalso mentions libvirtd, but there it quotes libvirt's general privilege model, which isstill accurate, so it is left as is.
The following alternatives were considered:
and people debugging a launcher see
virtqemudinps, so the concrete name is more useful.Links to places where the discussion took place: none
Special notes for your reviewer
Docs only.
Checklist
I used Claude (Anthropic) while reading the code and to draft the wording. I checked the process list on my own
cluster and reviewed every line. The commit carries an
Assisted-bytrailer.Release note