Skip to content

backend-storage: add RWO FS support - #12629

Merged
kubevirt-bot merged 15 commits into
kubevirt:mainfrom
jean-edouard:rwotpm
Oct 22, 2024
Merged

kubevirt-bot merged 15 commits into
kubevirt:mainfrom
jean-edouard:rwotpm

Conversation

@jean-edouard

Copy link
Copy Markdown
Contributor

What this PR does

See kubevirt/community#314

Before this PR:

After this PR:

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

backend-storage now supports RWO FS

@kubevirt-bot

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XL kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/compute sig/storage labels Aug 19, 2024
@jean-edouard

Copy link
Copy Markdown
Contributor Author

/test all

@jean-edouard

Copy link
Copy Markdown
Contributor Author

/test all

1 similar comment
@jean-edouard

Copy link
Copy Markdown
Contributor Author

/test all

@kubevirt-bot kubevirt-bot added the sig/buildsystem Denotes an issue or PR that relates to changes in the build system. label Aug 26, 2024
@jean-edouard

Copy link
Copy Markdown
Contributor Author

/test all

@jean-edouard

Copy link
Copy Markdown
Contributor Author

/test all

@jean-edouard jean-edouard changed the title WIP: backend-storage: add RWO FS support backend-storage: add RWO FS support Aug 28, 2024
@jean-edouard
jean-edouard marked this pull request as ready for review August 28, 2024 15:12
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2024
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2024
@fossedihelm

Copy link
Copy Markdown
Contributor

/test pull-kubevirt-check-tests-for-flakes

@dhiller

dhiller commented Oct 22, 2024

Copy link
Copy Markdown
Contributor

@jean-edouard kudos for the great idea to add a separate label for flake-check compatibility.
I figure we need to add the label here: https://github.com/kubevirt/kubevirt/blob/main/automation/repeated_test.sh#L199

Isn't that what I already do? :)

Yeah - glancing at this PR I just missed it, you are right 😊

Would you be up to creating a follow up PR marking all the other tests that have been filtered out in other ways? (Since I just came back I might have that in my emails - apologies for pinging you in that case)

Sure, do you have any pointers?

I was thinking about what is currently achieved with the exclude-native-ssh label but maybe @0xFelix has a better POV here about whether this makes sense. It wouldn't hurt to broadcast about this new label anyway, so that everyone knows, by i.e. adding a paragraph here :

## Writing e2e tests

@fossedihelm

Copy link
Copy Markdown
Contributor

Thank you for the patience @jean-edouard
/lgtm

@kubevirt-commenter-bot

Copy link
Copy Markdown

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.30-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-storage
/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-operator
/test pull-kubevirt-e2e-k8s-1.30-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-storage
/test pull-kubevirt-e2e-k8s-1.30-sig-compute
/test pull-kubevirt-e2e-k8s-1.30-sig-operator

@stu-gott

Copy link
Copy Markdown
Member

/retest-required

@kubevirt-bot

Copy link
Copy Markdown
Contributor

@jean-edouard: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-k8s-1.30-sig-storage 60b5db4 link unknown /test pull-kubevirt-e2e-k8s-1.30-sig-storage
pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations 60b5db4 link true /test pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations
pull-kubevirt-e2e-k8s-1.31-sig-network 60b5db4 link true /test pull-kubevirt-e2e-k8s-1.31-sig-network
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@alromeros

Copy link
Copy Markdown
Member

/test pull-kubevirt-e2e-k8s-1.31-sig-network
/test pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations

@xpivarc

xpivarc commented Nov 1, 2024

Copy link
Copy Markdown
Member

@jean-edouard The cache fixes are required in previous versions

@vladikr

vladikr commented Nov 5, 2024

Copy link
Copy Markdown
Member

@jean-edouard @acardace I noticed this PR only now, I didn't expect this would be merged if there are so many disagreements on the proposal!
This PR is also affected by the race mentioned in the proposal (https://issues.redhat.com/browse/CNV-50720) and #13112

@vladikr

vladikr commented Nov 5, 2024

Copy link
Copy Markdown
Member

@jean-edouard

Copy link
Copy Markdown
Contributor Author

@jean-edouard could you please open an upstream issue for https://issues.redhat.com/browse/CNV-50720

Wouldn't it be basically the same as #13112 ?

@vladikr

vladikr commented Nov 5, 2024

Copy link
Copy Markdown
Member

@jean-edouard could you please open an upstream issue for https://issues.redhat.com/browse/CNV-50720

Wouldn't it be basically the same as #13112 ?

It's similar, even if we fix #13112 we will still have a problem when the source and the target crash.

In #13112, the controller can observe that the target pod is happily running on the target already, so it can finalize the migration. (one possible solution)

in the case when the source and the target are gone, we don't know how to finalize the migration.
We don't know which volume was updated last.

As it is today if the source pod is gone without communicating the results to the handler we cannot tell which volume to choose when the VM starts again.

@alicefr

alicefr commented Nov 19, 2024

Copy link
Copy Markdown
Member

@jean-edouard could you please open an upstream issue for https://issues.redhat.com/browse/CNV-50720

Wouldn't it be basically the same as #13112 ?

It's similar, even if we fix #13112 we will still have a problem when the source and the target crash.

In #13112, the controller can observe that the target pod is happily running on the target already, so it can finalize the migration. (one possible solution)

in the case when the source and the target are gone, we don't know how to finalize the migration. We don't know which volume was updated last.

As it is today if the source pod is gone without communicating the results to the handler we cannot tell which volume to choose when the VM starts again.

@vladikr do you think we could solve this if it was possible also to query the migration status from the target libvirt? If now, we have 2 sources where we can get this information, then at least, if one is gone, we can always use the second one.

@iholder101

Copy link
Copy Markdown
Contributor

just a reminder - we should update the user-guide regarding this.

@enp0s3 enp0s3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jean-edouard Hi, perhaps I am missing something, but which component is responsible to sync the persistent data between the source PVC and the target PVC in case of RWO FS?

@jean-edouard

Copy link
Copy Markdown
Contributor Author

@jean-edouard Hi, perhaps I am missing something, but which component is responsible to sync the persistent data between the source PVC and the target PVC in case of RWO FS?

Libvirt takes care of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/buildsystem Denotes an issue or PR that relates to changes in the build system. sig/compute sig/storage size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.