Repository navigation
Log the storage class name, not its pointer, in filesystem overhead - #4320
Conversation
GetFilesystemOverheadForStorageClass passes the *string storage class name to klog.V(3).Info, which joins its arguments with fmt.Sprint. The log line therefore shows the pointer address and no spaces, e.g. "Storage class0x7035abda0020not found, trying default storage class". Use Infof with the dereferenced name instead. Assisted-by: Claude <[email protected]> Signed-off-by: YoungjuKim <[email protected]>
kubevirt-prow
Bot
added
release-note-none
|
Hi @fjvbn2003. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
akalenyu
left a comment
akalenyu
left a comment
There was a problem hiding this comment.
/approve
/lgtm
thanks!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-prow
Bot
added
the
approved
|
coverage: 50.213%. remained the same — fjvbn2003:fs-overhead-log-sc-name into kubevirt:main |
|
/retest-required |
|
@fjvbn2003: PRs from untrusted users cannot be marked as trusted with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The one failure in |
|
/override pull-containerized-data-importer-e2e-ceph-wffc |
|
@akalenyu: Overrode contexts on behalf of akalenyu: pull-containerized-data-importer-e2e-ceph-wffc DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
GetFilesystemOverheadForStorageClasspasses the*stringstorage class name toklog.V(3).Info, which joins itsarguments with
fmt.Sprint. At-v=3the two "storage class not found" lines therefore print the pointer addressand no spaces:
This switches both lines to
Infofwith the dereferenced name (ptr.Deref, already imported in this file):Which issue(s) this PR fixes:
None filed; found while reading the code.
Special notes for your reviewer:
Log-only change.
go vet ./pkg/controller/common/is clean andgo test ./pkg/controller/common/passes(43 of 43 specs, golang:1.27.2,
-mod=vendor).AI disclosure: I used Claude (Anthropic) to help find and write this change; I reviewed it and reproduced the log
output above. The commit carries an
Assisted-bytrailer.Release note: