Allow increasing PVC size to the minimum supported by its storage class by arnongilboa · Pull Request #3711 · kubevirt/containerized-data-importer

arnongilboa · 2025-04-23T13:45:54Z

What this PR does / why we need it:
Supports both DataVolume PVC rendering and PVC mutating webhook rendering, so it can cover the kubevirt-side created TPM small PVC and any other PVC created by DataVolume or independently. For independent PVCs they should be labeled with cdi.kubevirt.io/applyStorageProfile: "true" and CDI featureGate WebhookPvcRendering should be enabled. A StorageProfile can be annotated with its minimum supported volume size with e.g.:
cdi.kubevirt.io/minimumSupportedPvcSize: 4Gi

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Allow increasing PVC size to the minimum supported by its storage class

coveralls · 2025-04-23T14:34:27Z

coverage: 59.218% (+0.04%) from 59.18%
when pulling 8136697 on arnongilboa:set_min_pvc_size_per_sc_ann
into 247cf32 on kubevirt:main.

alromeros · 2025-04-29T09:19:30Z

/cc @alromeros

alromeros · 2025-04-29T16:00:25Z

+		if err := client.Get(context.TODO(), types.NamespacedName{Name: *scName}, storageClass); err == nil {
+			if val, exists := storageClass.Annotations[AnnMinimumSupportedPVCSize]; exists {
+				minSize, err := resource.ParseQuantity(val)
+				if err == nil && requestedSize.Cmp(minSize) == -1 {


I think it would be helpful to log or return an error if parsing the annotation fails, similar to what was done in the kubevirt PR. This way users can be notified if the annotation is set incorrectly.

awels

looks good, just the one comment by Alvaro.

Supports both DataVolume PVC rendering and PVC mutating webhook rendering, so it can cover the kubevirt-side created TPM small PVC and any other PVC created by DV or independently. For independent PVCs they should be labeled with cdi.kubevirt.io/applyStorageProfile: "true" and CDI featureGate WebhookPvcRendering should be enabled. A StorageProfile can be annotated with its minimum supported volume size with e.g.: cdi.kubevirt.io/minimumSupportedPvcSize: 4Gi Signed-off-by: Arnon Gilboa <[email protected]>

alromeros · 2025-05-02T05:32:26Z

/lgtm

awels

/approve

kubevirt-bot · 2025-05-02T11:53:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [awels]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

arnongilboa · 2025-05-05T09:21:40Z

/cherrypick release-v1.62

The feature is available since v1.59, and we enable it by default to allow increasing PVC size to the minimum supported by its provisioner (kubevirt#3711), and mainly in order to support: kubevirt/kubevirt#14637 Signed-off-by: Arnon Gilboa <[email protected]>

The feature is available since CDI v1.59, and we enable it by default to allow increasing PVC size to the minimum supported by its provisioner: kubevirt/containerized-data-importer#3711 and mainly in order to support: kubevirt/kubevirt#14637 Signed-off-by: Arnon Gilboa <[email protected]>

The feature is available since CDI v1.59, and we enable it by default to allow increasing PVC size to the minimum supported by its provisioner: kubevirt/containerized-data-importer#3711 and mainly in order to support: kubevirt/kubevirt#14637 Signed-off-by: Arnon Gilboa <[email protected]> Co-authored-by: Arnon Gilboa <[email protected]>

The feature is available since v1.59, and we enable it by default to allow increasing PVC size to the minimum supported by its provisioner (kubevirt#3711), and mainly in order to support: kubevirt/kubevirt#14637 Signed-off-by: Arnon Gilboa <[email protected]>

The feature is available since v1.59, and we enable it by default to allow increasing PVC size to the minimum supported by its provisioner (kubevirt#3711), and mainly in order to support: kubevirt/kubevirt#14637 As a bonus, the related Serial tests are now parallel. Thanks akalenyu:) Signed-off-by: Arnon Gilboa <[email protected]>

Follow-up of kubevirt#3711, annotating specifically: -pd.csi.storage.gke.io hyperdisk (4Gi) -ebs.csi.aws.com io1/io2 (4Gi) & gp2/gp3 (1Gi) Signed-off-by: Arnon Gilboa <[email protected]>

The feature is available since v1.59, and we enable it by default to allow increasing PVC size to the minimum supported by its provisioner (#3711), and mainly in order to support: kubevirt/kubevirt#14637 As a bonus, the related Serial tests are now parallel. Thanks akalenyu:) Signed-off-by: Arnon Gilboa <[email protected]>

The feature is available since v1.59, and we enable it by default to allow increasing PVC size to the minimum supported by its provisioner (kubevirt#3711), and mainly in order to support: kubevirt/kubevirt#14637 As a bonus, the related Serial tests are now parallel. Thanks akalenyu:) Signed-off-by: Arnon Gilboa <[email protected]>

The feature is available since v1.59, and we enable it by default to allow increasing PVC size to the minimum supported by its provisioner (#3711), and mainly in order to support: kubevirt/kubevirt#14637 As a bonus, the related Serial tests are now parallel. Thanks akalenyu:) Signed-off-by: Arnon Gilboa <[email protected]> Co-authored-by: Arnon Gilboa <[email protected]>

…3746) Follow-up of #3711, annotating specifically: -pd.csi.storage.gke.io hyperdisk (4Gi) -ebs.csi.aws.com io1/io2 (4Gi) & gp2/gp3 (1Gi) Signed-off-by: Arnon Gilboa <[email protected]>

Follow-up of kubevirt#3711, annotating specifically: -pd.csi.storage.gke.io hyperdisk (4Gi) -ebs.csi.aws.com io1/io2 (4Gi) & gp2/gp3 (1Gi) Signed-off-by: Arnon Gilboa <[email protected]>

The feature is available since CDI v1.59, and we enable it by default to allow increasing PVC size to the minimum supported by its provisioner: kubevirt/containerized-data-importer#3711 and mainly in order to support: kubevirt/kubevirt#14637 Signed-off-by: Arnon Gilboa <[email protected]> Co-authored-by: Arnon Gilboa <[email protected]>

…3758) Follow-up of #3711, annotating specifically: -pd.csi.storage.gke.io hyperdisk (4Gi) -ebs.csi.aws.com io1/io2 (4Gi) & gp2/gp3 (1Gi) Signed-off-by: Arnon Gilboa <[email protected]> Co-authored-by: Arnon Gilboa <[email protected]>

…3759) Follow-up of #3711, annotating specifically: -pd.csi.storage.gke.io hyperdisk (4Gi) -ebs.csi.aws.com io1/io2 (4Gi) & gp2/gp3 (1Gi) Signed-off-by: Arnon Gilboa <[email protected]> Co-authored-by: Arnon Gilboa <[email protected]>

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Apr 23, 2025

kubevirt-bot requested review from ShellyKa13 and aglitke April 23, 2025 13:47

arnongilboa force-pushed the set_min_pvc_size_per_sc_ann branch from 18f4f61 to 17f0bef Compare April 23, 2025 14:25

arnongilboa mentioned this pull request Apr 23, 2025

Backend storage: Allow specifying different PVC size kubevirt/kubevirt#13800

Closed

arnongilboa force-pushed the set_min_pvc_size_per_sc_ann branch from 17f0bef to c13fcfc Compare April 24, 2025 09:08

arnongilboa changed the title ~~Allow increating PVC size to the minimum supported by its storage class~~ Allow increasing PVC size to the minimum supported by its storage class Apr 24, 2025

arnongilboa force-pushed the set_min_pvc_size_per_sc_ann branch from c13fcfc to 1934b6c Compare April 24, 2025 09:09

kubevirt-bot requested a review from alromeros April 29, 2025 09:19

arnongilboa force-pushed the set_min_pvc_size_per_sc_ann branch from 1934b6c to dd94a7b Compare April 29, 2025 14:15

kubevirt-bot added size/M and removed size/S labels Apr 29, 2025

alromeros reviewed Apr 29, 2025

View reviewed changes

awels reviewed Apr 29, 2025

View reviewed changes

arnongilboa force-pushed the set_min_pvc_size_per_sc_ann branch from dd94a7b to e60536c Compare April 30, 2025 09:55

arnongilboa force-pushed the set_min_pvc_size_per_sc_ann branch from e60536c to 8136697 Compare April 30, 2025 10:09

kubevirt-bot assigned alromeros May 2, 2025

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2025

awels approved these changes May 2, 2025

View reviewed changes

kubevirt-bot assigned awels May 2, 2025

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2025

kubevirt-bot merged commit a43095f into kubevirt:main May 2, 2025

arnongilboa mentioned this pull request May 8, 2025

Enable WebhookPvcRendering feature gate by default #3736

Merged

arnongilboa mentioned this pull request May 8, 2025

Enable CDI WebhookPvcRendering feature gate by default kubevirt/hyperconverged-cluster-operator#3512

Merged

11 tasks

arnongilboa mentioned this pull request May 14, 2025

Annotate StorageProfiles with provisioner minimum supported PVC size #3746

Merged

jpeimer mentioned this pull request Sep 25, 2025

Fix the s390x tier2 storage tests which are failing due to missing DEFAULT_DV_SIZE. RedHatQE/openshift-virtualization-tests#2143

Merged

This was referenced Aug 5, 2026

Add minimumSupportedPvcSize for HPE XP (xspc.csi.hpe.com) and Hitachi HSPC (hspc.csi.hitachi.com) provisioners #4227

Closed

Add minimum supported PVC size for HPE XP and Hitachi HSPC provisioners #4228

Merged

coderabbitai Bot mentioned this pull request Aug 20, 2026

fix(cdi): update CDI to v1.66.1 cozystack/cozystack#3920

Merged

1 of 11 tasks

Navigation Menu

Repository navigation

Allow increasing PVC size to the minimum supported by its storage class - #3711

Allow increasing PVC size to the minimum supported by its storage class#3711
kubevirt-bot merged 1 commit into
kubevirt:mainfrom
arnongilboa:set_min_pvc_size_per_sc_ann

arnongilboa commented Apr 23, 2025 •

edited

Loading

Uh oh!

coveralls commented Apr 23, 2025 •

edited

Loading

Uh oh!

alromeros commented Apr 29, 2025

Uh oh!

alromeros Apr 29, 2025

Uh oh!

awels left a comment

Uh oh!

alromeros commented May 2, 2025

Uh oh!

awels left a comment

Uh oh!

kubevirt-bot commented May 2, 2025

Uh oh!

arnongilboa commented May 5, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

arnongilboa commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alromeros commented Apr 29, 2025

Uh oh!

alromeros Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

awels left a comment

Choose a reason for hiding this comment

Uh oh!

alromeros commented May 2, 2025

Uh oh!

awels left a comment

Choose a reason for hiding this comment

Uh oh!

kubevirt-bot commented May 2, 2025

Uh oh!

arnongilboa commented May 5, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

arnongilboa commented Apr 23, 2025 •

edited

Loading

coveralls commented Apr 23, 2025 •

edited

Loading