Repository navigation
Conversation
Signed-off-by: Andrei Kvapil <[email protected]>
Fixes panic, upstream issue: - kubevirt/cloud-provider-kubevirt#354 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved filtering and error handling for endpoints and virtual machines with missing or invalid data, ensuring only valid endpoints are processed. - **New Features** - Enhanced support for multi-cluster environments by introducing cluster name filtering for service and endpoint management. - **Tests** - Added new tests to verify correct handling of endpoints and services across clusters and improved coverage for edge cases. - **Chores** - Updated Kubernetes app and image versions for improved tracking and deployment consistency. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. /close |
|
@kubevirt-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@kvaps: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Rotten issues close after 30d of inactivity. /close |
|
@kubevirt-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Rotten issues close after 30d of inactivity. /close |
|
/reopen |
|
@kvaps: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Rotten issues close after 30d of inactivity. /close |
|
@kubevirt-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR addresses a potential panic in getDesiredEndpoints caused by dereferencing a nil NodeName field in EndpointSlice. The function now explicitly:
Additionally, a focused unit test has been added to validate correct handling of these edge cases.