Skip to content

📝 fix(security-links): address Copilot review on #8348#8355

Merged
clubanderson merged 1 commit intomainfrom
fix/8352-copilot-followup
Apr 16, 2026
Merged

📝 fix(security-links): address Copilot review on #8348#8355
clubanderson merged 1 commit intomainfrom
fix/8352-copilot-followup

Conversation

@clubanderson
Copy link
Copy Markdown
Collaborator

@clubanderson clubanderson commented Apr 16, 2026

Summary

Addresses the four Copilot-generated review nits from #8352 on the merged #8348.

  • Rewrote the misleading "Falls back to" comment on SECURITY_DOC_URL in SetupInstructionsDialog.tsx — both links are shown side-by-side, not in a fallback chain.
  • Fixed inconsistent label (docs.kubestellar.io) → (kubestellar.io) in SetupInstructionsDialog.tsx to match the actual host of SECURITY_DOC_URL.
  • Corrected MissionDetailView.tsx docstring from docs.kubestellar.io → kubestellar.io for the same constant.
  • Aligned link text AI threat model → AI automation threat model in MissionDetailView.tsx so both entry points read the same.

Fixes #8352

Test plan

  • npm run build passes
  • No functional changes — comments + label copy only

@clubanderson
📝 fix(security-links): address Copilot review on #8348
5de86e5 
Copilot-generated followup #8352 flagged four nits on the merged
security-links PR (#8348):

- Misleading "Falls back to" comment on SECURITY_DOC_URL — both links
  are surfaced side-by-side, not as a fallback chain. Rewrote to
  describe the actual behavior.
- Link label "(docs.kubestellar.io)" didn't match the actual host
  ("kubestellar.io") in SetupInstructionsDialog. Matched the label
  to the URL.
- MissionDetailView docstring referenced "docs.kubestellar.io" for
  the SECURITY_MODEL_DOC_URL constant; URL is "kubestellar.io".
- Link text "AI threat model" was inconsistent with
  SetupInstructionsDialog which uses "AI automation threat model".
  Aligned wording so both entry points read the same.

Fixes #8352

Signed-off-by: Andy Anderson <[email protected]>
Copilot AI review requested due to automatic review settings April 16, 2026 12:01
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Apr 16, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented Apr 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clubanderson clubanderson added the ai-generated Pull request generated by AI label Apr 16, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 16, 2026 •
edited
Loading

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 5de86e5
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/69e0cf8bddc6e100088bd790
😎 Deploy Preview https://deploy-preview-8355.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 16, 2026
Copilot AI reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Follow-up copy/comment-only cleanup to align the Console security documentation link labels and docstrings with the actual kubestellar.io URL and to make the AI threat model link text consistent across UI entry points.

Changes:

  • Reworded the SECURITY_DOC_URL inline comment to remove “fallback” implications (links are displayed side-by-side).
  • Updated visible host labels from docs.kubestellar.io to kubestellar.io where the actual URL host is kubestellar.io.
  • Standardized “AI automation threat model” link text in the mission Security tab empty state to match the footer.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
web/src/components/setup/SetupInstructionsDialog.tsx Adjusts security-doc constant comment and aligns the rendered link label with the kubestellar.io host shown in the href.
web/src/components/missions/MissionDetailView.tsx Updates the security-doc docstring host and makes AI threat-model link text consistent.

@clubanderson clubanderson merged commit 64b1ae3 into main Apr 16, 2026
29 of 30 checks passed
@clubanderson clubanderson deleted the fix/8352-copilot-followup branch April 16, 2026 12:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 64b1ae3ddce80b352d38d25f98ca09194e3cf55f.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

❌ Post-Merge Verification: failed

Commit: 64b1ae3ddce80b352d38d25f98ca09194e3cf55f
Specs run: Missions.spec.ts mission-import.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/24509493442

@github-actions github-actions Bot mentioned this pull request Apr 16, 2026
Closed
@clubanderson clubanderson mentioned this pull request Apr 16, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

ai-generated Pull request generated by AI dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tier/2-standard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Copilot Review] 4 comment(s) on merged PR #8348

2 participants

@clubanderson