📝 docs(security): address Copilot findings on SECURITY-MODEL.md + README (#8207) by clubanderson · Pull Request #8223 · kubestellar/console

clubanderson · 2026-04-15T19:46:22Z

Addresses all 6 Copilot review comments from the merged security docs bundle (PR #8203). Each claim was verified against source before applying.

Verifications run

grep -n "InitializeProviders\|RegisterProvider" pkg/agent/*.go → confirmed InitializeProviders (pkg/agent/registry.go:283) registers only CLI-based tool agents (claude-code, bob, codex, gemini-cli, antigravity, goose, copilot-cli) and explicitly excludes API-only HTTP providers at pkg/agent/registry.go:303-307.
find . -name update_checker.go → lives at pkg/agent/update_checker.go (local kc-agent), not in the Go backend.
grep -n "DEV_MODE\|KC_DEV_MODE" → DEV_MODE is read in cmd/kc-agent/main.go:18 (general kc-agent dev/logging toggle); KC_DEV_MODE=1 is read only in pkg/agent/server_http.go:2202 for the backend-driven agent restart path.

Findings addressed

README.md:174 — OpenAI-compatible local LLM claim. Reframed the "security model" paragraph so it no longer implies GROQ_BASE_URL / OPENROUTER_BASE_URL / OPEN_WEBUI_URL enable a selectable provider today. Marked as a planned follow-up. Points readers at the currently supported CLI-based agent path.
SECURITY-MODEL.md §1 data flow (~line 108) — CLI vs HTTP distinction. Replaced the "Key consequence" block with a two-path description: CLI tool agents (which execute kubectl/helm locally and may forward tool output upstream) vs direct HTTP providers (where the request body is built in pkg/agent/provider_*.go). Notes that API-only HTTP providers are not registered at runtime today.
SECURITY-MODEL.md §2 Posture B (~line 142) — AI gating condition. Rewrote the restricted-egress section to match runtime reality: AI is gated by registered CLI agent availability, not by API-key env vars. *_API_KEY vars do not by themselves enable AI. Settings → API Keys modal treated as non-operative for current runtime enablement.
SECURITY-MODEL.md §1 "what leaves the cluster" (~line 122) — update_checker.go location. Corrected the reference: the local kc-agent (pkg/agent/update_checker.go) performs GitHub update polling, not the in-cluster backend pod. Separated the GitHub OAuth call site from the update-check call site in the bullet list.
SECURITY-MODEL.md §3 Local / Self-Hosted LLMs (~line 184) — "supported" claim. Added a prominent "Current registration status" subsection stating that Groq/OpenRouter/Open WebUI (and Claude API/OpenAI/Gemini) provider implementations exist in pkg/agent/provider_*.go but are not registered by InitializeProviders. Base-URL env vars relabeled as "parsed, not wired". Moved the Ollama / vLLM / LM Studio / internal-gateway recipes under a "Planned follow-up" subsection and annotated every code block with # PLANNED — not yet wired at runtime. Preserved the mermaid diagrams added in PR 📝 docs(security): add mermaid diagrams to SECURITY-MODEL.md #8206.
SECURITY-MODEL.md §4 env var cheat sheet (~line 264) — DEV_MODE vs KC_DEV_MODE. Split the single KC_DEV_MODE row into two: DEV_MODE (general kc-agent dev/logging) and KC_DEV_MODE (backend-driven restart path) so operators don't set the wrong variable.

Notes

Rebased cleanly on top of PR 📝 docs(security): add mermaid diagrams to SECURITY-MODEL.md #8206 (mermaid diagrams), which landed during this fix. No content from 📝 docs(security): add mermaid diagrams to SECURITY-MODEL.md #8206 was clobbered.
Docs-only change. web/ npm run build and web/ npm run lint both pass locally.

🤖 Generated with Claude Code

…DME (#8207) Fixes #8207 Addresses all 6 Copilot review comments from PR #8203 (security docs bundle). Verified each claim against source before applying: - Verified InitializeProviders (pkg/agent/registry.go:283) registers only CLI-based tool agents and explicitly excludes API-key HTTP providers (claude/openai/gemini/groq/openrouter/open-webui). - Verified update_checker.go lives in pkg/agent/ (local kc-agent), not in the Go backend server pod. - Verified DEV_MODE is read in cmd/kc-agent/main.go:18 while KC_DEV_MODE=1 is only used in pkg/agent/server_http.go:2202 for the backend-driven agent restart path. Changes: 1. README.md (finding #1): The "security model" paragraph no longer claims users can point an OpenAI-compatible local LLM at kc-agent via GROQ_BASE_URL / OPENROUTER_BASE_URL / OPEN_WEBUI_URL today. Reframed as a planned follow-up; currently supported path is the CLI-based agents. 2. SECURITY-MODEL.md §1 data flow (finding #2): Replaced the single-sentence "Key consequence" block with the two-path distinction (CLI tool agents vs direct HTTP providers). Notes that CLI agents can exfiltrate cluster data indirectly via kubectl/helm tool output; direct HTTP providers are not registered at runtime today. 3. SECURITY-MODEL.md §2 Posture B (finding #3): Rewrote the restricted-egress section to match runtime reality. AI gating is by registered CLI agent availability, not by API-key env vars. Setting *_API_KEY does not by itself enable AI. Settings → API Keys modal documented as non-operative. 4. SECURITY-MODEL.md §1 "leaves the cluster" (finding #5): Corrected the update_checker.go reference. The local kc-agent (not the backend pod) performs any GitHub update polling. In-cluster backend deployments do not poll GitHub from the server pod. 5. SECURITY-MODEL.md §3 Local/Self-hosted LLMs (finding #4): Added a prominent "current registration status" subsection stating that Groq/OpenRouter/Open WebUI provider implementations exist but are NOT registered by InitializeProviders. Relabeled the Ollama / vLLM / LM Studio / internal-gateway recipes as "planned follow-up" (not operative today). Base-URL env vars noted as "parsed, not wired". Retained the mermaid diagrams from PR #8206 and framed them as the intended direction. 6. SECURITY-MODEL.md §4 env var cheat sheet (finding #6): Split the KC_DEV_MODE row into two entries — DEV_MODE (general kc-agent dev/logging toggle, read in cmd/kc-agent/main.go) and KC_DEV_MODE (backend-driven restart/dev path in pkg/agent/server_http.go) — so operators don't set the wrong variable. Docs-only change. web build + lint pass. Signed-off-by: Andy Anderson <[email protected]>

kubestellar-prow · 2026-04-15T19:46:28Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2026-04-15T19:46:28Z

✅ Deploy Preview for kubestellarconsole ready!

Name	Link
🔨 Latest commit	`49e90e3`
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/69dfeb11b5ab4e0008a735a4
😎 Deploy Preview	https://deploy-preview-8223.console-deploy-preview.kubestellar.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-04-15T19:46:51Z

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

Claude Code (Opus 4.5 / 4.6) — recommended

GitHub Copilot

Cursor

Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

Copilot

Pull request overview

Docs-only follow-up to #8203/#8206 that corrects security-model wording to match current kc-agent runtime behavior (CLI-agent-only registration, update checks running locally, and DEV_MODE vs KC_DEV_MODE).

Changes:

Clarifies AI egress paths by separating CLI tool agents vs direct HTTP providers, and documents that HTTP providers aren’t selectable at runtime today.
Corrects “what leaves the cluster” to reflect that update checks run in the local kc-agent (not the in-cluster backend pod).
Updates Posture B guidance and the env-var cheat sheet (DEV_MODE vs KC_DEV_MODE).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
docs/security/SECURITY-MODEL.md	Aligns security/egress/provider claims with current provider registry behavior and update-check location; refines env-var guidance.
README.md	Rewords the security-model link paragraph to avoid implying local LLM base-URL overrides are supported today.

Copilot · 2026-04-15T19:50:51Z

+### Important: current registration status
+
+The provider implementations for **Groq**, **OpenRouter**, and **Open WebUI** (and the other API-key HTTP providers such as Claude API, OpenAI, and Gemini) exist in `pkg/agent/provider_*.go`, **but they are not registered by `InitializeProviders`** in the current build. They are explicitly excluded as "API-only agents" (see `pkg/agent/registry.go:303-307`) because the active runtime registry only registers CLI-based tool-capable agents (`claude-code`, `bob`, `codex`, `gemini-cli`, `antigravity`, `goose`, `copilot-cli`). As a result, **these HTTP providers cannot currently be selected via the runtime provider registry**, and their `*_BASE_URL` environment variables are parsed by the provider source files but are **not** wired into a selectable provider at runtime.
+
+The currently supported self-hosted path is therefore the CLI tool-agent path: install one of the supported local CLIs (for example `claude-code`, `codex`, or `gemini-cli`) on the machine that runs kc-agent, and it will be picked up by `InitializeProviders`.

-| Provider | `provider` name | API key env var | Model env var | Base URL overridable? | Base URL env var | Source |
+### Provider source files and env vars (reference)
+
+The table below documents the provider implementations that exist in the source tree and the env vars they parse. Rows marked "Registered?" as **no** are not currently selectable at runtime.
+
+| Provider | `provider` name | API key env var | Model env var | Base URL env var | Registered? | Source |
 |---|---|---|---|---|---|---|
-| Anthropic Claude | `claude` / `anthropic` | `ANTHROPIC_API_KEY` | `CLAUDE_MODEL` | no (fixed to Anthropic) | — | `pkg/agent/provider_claude.go` |
-| OpenAI (ChatGPT) | `openai` | `OPENAI_API_KEY` | `OPENAI_MODEL` | no (fixed to `api.openai.com`) | — | `pkg/agent/provider_openai.go:15` |
-| Google Gemini | `gemini` / `google` | `GOOGLE_API_KEY` | `GEMINI_MODEL` | no | — | `pkg/agent/provider_gemini.go:15` |
-| Groq (OpenAI-compatible) | `groq` | `GROQ_API_KEY` | `GROQ_MODEL` | **yes** | `GROQ_BASE_URL` | `pkg/agent/provider_groq.go:22-51` |
-| OpenRouter (OpenAI-compatible) | `openrouter` | `OPENROUTER_API_KEY` | `OPENROUTER_MODEL` | **yes** | `OPENROUTER_BASE_URL` | `pkg/agent/provider_openrouter.go:23-58` |
-| Open WebUI (OpenAI-compatible) | `open-webui` | `OPEN_WEBUI_API_KEY` | `OPEN_WEBUI_MODEL` | **yes** | `OPEN_WEBUI_URL` | `pkg/agent/provider_openwebui.go:16,39` |
+| Anthropic Claude (HTTP) | `claude` / `anthropic` | `ANTHROPIC_API_KEY` | `CLAUDE_MODEL` | — | no | `pkg/agent/provider_claude.go` |
+| OpenAI (ChatGPT, HTTP) | `openai` | `OPENAI_API_KEY` | `OPENAI_MODEL` | — | no | `pkg/agent/provider_openai.go:15` |
+| Google Gemini (HTTP) | `gemini` / `google` | `GOOGLE_API_KEY` | `GEMINI_MODEL` | — | no | `pkg/agent/provider_gemini.go:15` |
+| Groq (OpenAI-compatible, HTTP) | `groq` | `GROQ_API_KEY` | `GROQ_MODEL` | `GROQ_BASE_URL` (parsed, not wired) | no | `pkg/agent/provider_groq.go:22-51` |
+| OpenRouter (OpenAI-compatible, HTTP) | `openrouter` | `OPENROUTER_API_KEY` | `OPENROUTER_MODEL` | `OPENROUTER_BASE_URL` (parsed, not wired) | no | `pkg/agent/provider_openrouter.go:23-58` |
+| Open WebUI (OpenAI-compatible, HTTP) | `open-webui` | `OPEN_WEBUI_API_KEY` | `OPEN_WEBUI_MODEL` | `OPEN_WEBUI_URL` (parsed, not wired) | no | `pkg/agent/provider_openwebui.go:16,39` |
+
+Note the asymmetry: the upstream OpenAI provider source file hard-codes its hostname as a package-level variable in `pkg/agent/provider_openai.go:15` (no `OPENAI_BASE_URL` override). Groq, OpenRouter, and Open WebUI do parse base-URL env vars, but because those providers are not registered at runtime today, setting those env vars does not actually route AI traffic through a local endpoint.
+
+### Planned follow-up: wire up OpenAI-compatible local LLMs

-Note the asymmetry: **the upstream OpenAI provider does not currently honor an `OPENAI_BASE_URL` override.** The hostname is a package-level variable in `pkg/agent/provider_openai.go:15`, but it is not re-read from the environment. If you want to point an OpenAI-compatible local server at the console today, use one of the three providers whose base URLs *are* overridable: **Groq, OpenRouter, or Open WebUI**. All three speak the OpenAI chat-completions wire format.
+The diagrams and examples below describe the **planned** configuration shape once the base-URL-overridable HTTP providers are registered in `InitializeProviders`. They are **not operative in the current build** — treat them as forward-looking documentation. If/when the providers are wired in, this section will be promoted back to a supported recipe.



This “current registration status / planned follow-up” section now documents that the OpenAI-compatible HTTP providers (Groq/OpenRouter/Open WebUI) are not selectable at runtime, but the document’s opening summary still states local/self-hosted LLMs are supported “Yes, via” those providers. Please update the earlier summary/question phrasing to match the new reality (planned/not yet wired) to avoid a contradictory “supported today” impression.

Copilot · 2026-04-15T19:50:51Z

 | `KC_AGENT_TOKEN` | kc-agent | Optional shared secret for browser→agent auth |
 | `KC_ALLOWED_ORIGINS` | kc-agent | Extra allowed origins (comma-separated) |
-| `KC_DEV_MODE` | kc-agent | Development mode toggle (`1` to enable) |
+| `DEV_MODE` | kc-agent | General kc-agent development/logging mode toggle |


The cheat sheet lists DEV_MODE as a generic kc-agent dev/logging toggle but doesn’t document the expected value. In cmd/kc-agent/main.go, the toggle is os.Getenv("DEV_MODE") == "true" (not 1). Please note the required value (e.g., DEV_MODE=true) to prevent operators from setting DEV_MODE=1 and expecting it to work.

Suggested change

| `DEV_MODE` | kc-agent | General kc-agent development/logging mode toggle |

| `DEV_MODE` | kc-agent | General kc-agent development/logging mode toggle; set `DEV_MODE=true` to enable (the code checks for the literal string `true`) |

Copilot · 2026-04-15T19:50:51Z

-Key consequence: **the kubeconfig, raw secrets, and cluster credentials never cross the process boundary from kc-agent.** The only thing kc-agent sends outward is the HTTP chat payload to the configured AI provider, which contains the conversation the user has been having (system prompt + message history + current prompt — see `pkg/agent/provider_openai.go:207-238` for the exact OpenAI shape).
+Key consequence: **the kubeconfig, raw secrets, and cluster credentials never cross the process boundary from kc-agent as direct credential uploads.** However, the data that can leave the machine depends on which kind of AI agent is configured:
+
+- **CLI tool agents** (for example `claude-code`, `codex`, `gemini-cli`) run an external CLI locally. These agents can execute tools such as `kubectl` and `helm`, and the external CLI may send tool output or other cluster-derived context to its upstream LLM depending on the agent's behavior and the prompt. In the current build, `InitializeProviders` (`pkg/agent/registry.go:283`) registers **only** CLI-based tool-capable agents — `claude-code`, `bob`, `codex`, `gemini-cli`, `antigravity`, `goose`, and `copilot-cli`.


The “CLI tool agents” paragraph describes all registered agents as tool-capable (“can execute tools such as kubectl and helm”) and includes antigravity in the list of “tool-capable agents”. In code, AntigravityProvider.Capabilities() returns CapabilityChat only (no tool execution), so this overstates capabilities and could mislead operators about what data can be pulled via tools. Please either remove antigravity from the tool-capable list or qualify it as chat-only / non-tool-executing, and scope the kubectl/helm statement to agents that actually have CapabilityToolExec.

Suggested change

- **CLI tool agents** (for example `claude-code`, `codex`, `gemini-cli`) run an external CLI locally. These agents can execute tools such as `kubectl` and `helm`, and the external CLI may send tool output or other cluster-derived context to its upstream LLM depending on the agent's behavior and the prompt. In the current build, `InitializeProviders` (`pkg/agent/registry.go:283`) registers **only** CLI-based tool-capable agents — `claude-code`, `bob`, `codex`, `gemini-cli`, `antigravity`, `goose`, and `copilot-cli`.

- **CLI-based agents** run an external CLI locally. For the registered agents that have tool-execution capability (for example `claude-code`, `bob`, `codex`, `gemini-cli`, `goose`, and `copilot-cli`), the agent can execute tools such as `kubectl` and `helm`, and the external CLI may send tool output or other cluster-derived context to its upstream LLM depending on the agent's behavior and the prompt. In the current build, `InitializeProviders` (`pkg/agent/registry.go:283`) registers those CLI-based tool-capable agents, and also registers `antigravity`, which is CLI-based but chat-only / non-tool-executing.

Copilot · 2026-04-15T19:50:52Z

-### Supported providers and env vars
+### Important: current registration status
+
+The provider implementations for **Groq**, **OpenRouter**, and **Open WebUI** (and the other API-key HTTP providers such as Claude API, OpenAI, and Gemini) exist in `pkg/agent/provider_*.go`, **but they are not registered by `InitializeProviders`** in the current build. They are explicitly excluded as "API-only agents" (see `pkg/agent/registry.go:303-307`) because the active runtime registry only registers CLI-based tool-capable agents (`claude-code`, `bob`, `codex`, `gemini-cli`, `antigravity`, `goose`, `copilot-cli`). As a result, **these HTTP providers cannot currently be selected via the runtime provider registry**, and their `*_BASE_URL` environment variables are parsed by the provider source files but are **not** wired into a selectable provider at runtime.


This section says Groq/OpenRouter/Open WebUI are “explicitly excluded as "API-only agents" (see pkg/agent/registry.go:303-307)”. That comment only names Claude API/OpenAI/Gemini and IDE agents; it doesn’t mention Groq/OpenRouter/Open WebUI. Since they’re simply not registered today (no registry.Register(NewGroqProvider()), etc.), please reword to avoid claiming the registry comment explicitly excludes those providers, or add a more accurate citation/wording (e.g., “not registered by InitializeProviders”).

Suggested change

The provider implementations for **Groq**, **OpenRouter**, and **Open WebUI** (and the other API-key HTTP providers such as Claude API, OpenAI, and Gemini) exist in `pkg/agent/provider_*.go`, **but they are not registered by `InitializeProviders`** in the current build. They are explicitly excluded as "API-only agents" (see `pkg/agent/registry.go:303-307`) because the active runtime registry only registers CLI-based tool-capable agents (`claude-code`, `bob`, `codex`, `gemini-cli`, `antigravity`, `goose`, `copilot-cli`). As a result, **these HTTP providers cannot currently be selected via the runtime provider registry**, and their `*_BASE_URL` environment variables are parsed by the provider source files but are **not** wired into a selectable provider at runtime.

The provider implementations for **Groq**, **OpenRouter**, and **Open WebUI** (and the other API-key HTTP providers such as Claude API, OpenAI, and Gemini) exist in `pkg/agent/provider_*.go`, **but they are not registered by `InitializeProviders`** in the current build. The active runtime registry currently registers only CLI-based tool-capable agents (`claude-code`, `bob`, `codex`, `gemini-cli`, `antigravity`, `goose`, `copilot-cli`; see `pkg/agent/registry.go:303-307`). As a result, **these HTTP providers cannot currently be selected via the runtime provider registry**, and their `*_BASE_URL` environment variables are parsed by the provider source files but are **not** wired into a selectable provider at runtime.

github-actions · 2026-04-15T19:57:01Z

Thank you for your contribution! Your PR has been merged.

Check out what's new:

KubeStellar Console — Live multi-cluster dashboard
Marketplace — Community extensions
Knowledge Base — Troubleshooting and how-tos

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

github-actions · 2026-04-15T19:59:30Z

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 633689c0243967cad4900bf4e50545fc46abcdf3.

clubanderson added the ai-generated Pull request generated by AI label Apr 15, 2026

Copilot AI review requested due to automatic review settings April 15, 2026 19:46

kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Apr 15, 2026

kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 15, 2026

Copilot started reviewing on behalf of clubanderson April 15, 2026 19:47 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

clubanderson merged commit 633689c into main Apr 15, 2026
55 of 56 checks passed

clubanderson deleted the fix/security-docs-copilot-8207 branch April 15, 2026 19:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

📝 docs(security): address Copilot findings on SECURITY-MODEL.md + README (#8207)#8223

📝 docs(security): address Copilot findings on SECURITY-MODEL.md + README (#8207)#8223
clubanderson merged 1 commit intomainfrom
fix/security-docs-copilot-8207

clubanderson commented Apr 15, 2026

Uh oh!

kubestellar-prow Bot commented Apr 15, 2026

Uh oh!

netlify Bot commented Apr 15, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	\| `DEV_MODE` \| kc-agent \| General kc-agent development/logging mode toggle \|
	\| `DEV_MODE` \| kc-agent \| General kc-agent development/logging mode toggle; set `DEV_MODE=true` to enable (the code checks for the literal string `true`) \|

Conversation

clubanderson commented Apr 15, 2026

Verifications run

Findings addressed

Notes

Uh oh!

kubestellar-prow Bot commented Apr 15, 2026

Uh oh!

netlify Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubestellarconsole ready!

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented Apr 15, 2026 •

edited

Loading