🐛 Fix docs feedback commit URL using wrong repo name#11177
Conversation
Co-authored-by: Copilot <[email protected]> Signed-off-by: Copilot <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole canceled.
|
|
👋 Hey @clubanderson — thanks for opening this PR!
This is an automated message. |
There was a problem hiding this comment.
Pull request overview
Fixes an issue in the GitHub docs feedback handler where the generated commit (SHA) link could incorrectly point to the target repo (e.g., docs) instead of the console repo where the commit actually exists.
Changes:
- Build the SHA/commit URL using
h.repoOwner/h.repoName(console repo) instead of the target repo parameters.
| shortSHA = shortSHA[:shortSHALen] | ||
| } | ||
| shaLine = fmt.Sprintf("\nSHA: [`%s`](https://github.com/%s/%s/commit/%s)\n", shortSHA, repoOwner, repoName, fullSHA) | ||
| shaLine = fmt.Sprintf("\nSHA: [`%s`](https://github.com/%s/%s/commit/%s)\n", shortSHA, h.repoOwner, h.repoName, fullSHA) |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
❌ Post-Merge Verification: failedCommit: |
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
…n, type signatures - feedback_config.go: add resolveGitHubUIBase() for GHE-aware web link construction - feedback_github.go: use resolveGitHubUIBase() for SHA commit link (#11177 follow-up) - ComplianceReports.tsx: clear selectedCluster when it's filtered out by reachability (was only auto-set when empty, leaving stale selection pointing to hidden cluster) - ComplianceReports.tsx + ControlPlaneHealth.tsx: fix misleading 'only reachable' comments — predicate c.reachable !== false also includes undefined (not-yet-checked) - dedup.ts: widen shareMetricsBetweenSameServerClusters signature to ClusterInfo[] | null | undefined to match the runtime guard already in the body (#11184 medium) - shared.ts: fix dedup priority comment — reachability is criterion #1, not #2 Co-authored-by: Copilot <[email protected]> Signed-off-by: Copilot <[email protected]>
* 🐛 Fix incorrect assertion in agentFetch 401 retry test Co-authored-by: Copilot <[email protected]> Signed-off-by: Copilot <[email protected]> * test: batch 16 coverage — preflightCheck, useClusterContext, sampleData (#11192) * test: add batch 16 coverage tests for preflightCheck, useClusterContext, sampleData Add 116 tests across 3 files to push line coverage past 90.50%: - preflightCheck-coverage (67 tests): classifyKubectlError, resolveRequiredTools, runToolPreflightCheck - useClusterContext-coverage (17 tests): operator name stripping, helm chart parsing, pod issues - sampleData-coverage (32 tests): field heuristics, detectFieldFormat edge cases Signed-off-by: Andrew Anderson <[email protected]> * fix: change savedCards/sharedDashboards to let for reassignment in resetShareRegistries Signed-off-by: Andrew Anderson <[email protected]> --------- Signed-off-by: Andrew Anderson <[email protected]> * 🐛 Fix medium Copilot comments: GHE commit URL, stale cluster selection, type signatures - feedback_config.go: add resolveGitHubUIBase() for GHE-aware web link construction - feedback_github.go: use resolveGitHubUIBase() for SHA commit link (#11177 follow-up) - ComplianceReports.tsx: clear selectedCluster when it's filtered out by reachability (was only auto-set when empty, leaving stale selection pointing to hidden cluster) - ComplianceReports.tsx + ControlPlaneHealth.tsx: fix misleading 'only reachable' comments — predicate c.reachable !== false also includes undefined (not-yet-checked) - dedup.ts: widen shareMetricsBetweenSameServerClusters signature to ClusterInfo[] | null | undefined to match the runtime guard already in the body (#11184 medium) - shared.ts: fix dedup priority comment — reachability is criterion #1, not #2 Co-authored-by: Copilot <[email protected]> Signed-off-by: Copilot <[email protected]> --------- Signed-off-by: Copilot <[email protected]> Signed-off-by: Andrew Anderson <[email protected]> Co-authored-by: Copilot <[email protected]>
Signed-off-by: Copilot <[email protected]> Co-authored-by: Copilot <[email protected]> Signed-off-by: lightyagami2109 <[email protected]>
…1202) * 🐛 Fix incorrect assertion in agentFetch 401 retry test Co-authored-by: Copilot <[email protected]> Signed-off-by: Copilot <[email protected]> * test: batch 16 coverage — preflightCheck, useClusterContext, sampleData (kubestellar#11192) * test: add batch 16 coverage tests for preflightCheck, useClusterContext, sampleData Add 116 tests across 3 files to push line coverage past 90.50%: - preflightCheck-coverage (67 tests): classifyKubectlError, resolveRequiredTools, runToolPreflightCheck - useClusterContext-coverage (17 tests): operator name stripping, helm chart parsing, pod issues - sampleData-coverage (32 tests): field heuristics, detectFieldFormat edge cases Signed-off-by: Andrew Anderson <[email protected]> * fix: change savedCards/sharedDashboards to let for reassignment in resetShareRegistries Signed-off-by: Andrew Anderson <[email protected]> --------- Signed-off-by: Andrew Anderson <[email protected]> * 🐛 Fix medium Copilot comments: GHE commit URL, stale cluster selection, type signatures - feedback_config.go: add resolveGitHubUIBase() for GHE-aware web link construction - feedback_github.go: use resolveGitHubUIBase() for SHA commit link (kubestellar#11177 follow-up) - ComplianceReports.tsx: clear selectedCluster when it's filtered out by reachability (was only auto-set when empty, leaving stale selection pointing to hidden cluster) - ComplianceReports.tsx + ControlPlaneHealth.tsx: fix misleading 'only reachable' comments — predicate c.reachable !== false also includes undefined (not-yet-checked) - dedup.ts: widen shareMetricsBetweenSameServerClusters signature to ClusterInfo[] | null | undefined to match the runtime guard already in the body (kubestellar#11184 medium) - shared.ts: fix dedup priority comment — reachability is criterion kubestellar#1, not kubestellar#2 Co-authored-by: Copilot <[email protected]> Signed-off-by: Copilot <[email protected]> --------- Signed-off-by: Copilot <[email protected]> Signed-off-by: Andrew Anderson <[email protected]> Co-authored-by: Copilot <[email protected]> Signed-off-by: lightyagami2109 <[email protected]>
Fixes #11165
h.repoOwner/h.repoName(the console repo) instead of the function parametersrepoOwner/repoName(the target repo) when constructing commit URLs in docs feedback handler