Skip to content

🐛 Fix docs feedback commit URL using wrong repo name#11177

Merged
clubanderson merged 1 commit intomainfrom
fix/11165
Apr 30, 2026
Merged

🐛 Fix docs feedback commit URL using wrong repo name#11177
clubanderson merged 1 commit intomainfrom
fix/11165

Conversation

@clubanderson
Copy link
Copy Markdown
Collaborator

Fixes #11165

  • Use h.repoOwner/h.repoName (the console repo) instead of the function parameters repoOwner/repoName (the target repo) when constructing commit URLs in docs feedback handler

Copilot AI review requested due to automatic review settings April 30, 2026 23:42
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Apr 30, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eeshaansa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 30, 2026

Deploy Preview for kubestellarconsole canceled.

Name Link
🔨 Latest commit 51214ce
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/69f3e8f70acc7d00079c41bc

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2026
@github-actions github-actions Bot added the ai-generated Pull request generated by AI label Apr 30, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an issue in the GitHub docs feedback handler where the generated commit (SHA) link could incorrectly point to the target repo (e.g., docs) instead of the console repo where the commit actually exists.

Changes:

  • Build the SHA/commit URL using h.repoOwner/h.repoName (console repo) instead of the target repo parameters.

shortSHA = shortSHA[:shortSHALen]
}
shaLine = fmt.Sprintf("\nSHA: [`%s`](https://github.com/%s/%s/commit/%s)\n", shortSHA, repoOwner, repoName, fullSHA)
shaLine = fmt.Sprintf("\nSHA: [`%s`](https://github.com/%s/%s/commit/%s)\n", shortSHA, h.repoOwner, h.repoName, fullSHA)
@clubanderson clubanderson merged commit 35a9fd7 into main Apr 30, 2026
37 of 38 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the fix/11165 branch April 30, 2026 23:50
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@github-actions
Copy link
Copy Markdown
Contributor

❌ Post-Merge Verification: failed

Commit: 35a9fd76d7b75630ba17e27dc5e97581f284b24d
Specs run: smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/25195121760

@github-actions
Copy link
Copy Markdown
Contributor

Post-merge build verification passed

Both Go and frontend builds compiled successfully against merge commit 35a9fd76d7b75630ba17e27dc5e97581f284b24d.

clubanderson pushed a commit that referenced this pull request May 1, 2026
…n, type signatures

- feedback_config.go: add resolveGitHubUIBase() for GHE-aware web link construction
- feedback_github.go: use resolveGitHubUIBase() for SHA commit link (#11177 follow-up)
- ComplianceReports.tsx: clear selectedCluster when it's filtered out by reachability
  (was only auto-set when empty, leaving stale selection pointing to hidden cluster)
- ComplianceReports.tsx + ControlPlaneHealth.tsx: fix misleading 'only reachable'
  comments — predicate c.reachable !== false also includes undefined (not-yet-checked)
- dedup.ts: widen shareMetricsBetweenSameServerClusters signature to ClusterInfo[] |
  null | undefined to match the runtime guard already in the body (#11184 medium)
- shared.ts: fix dedup priority comment — reachability is criterion #1, not #2

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Copilot <[email protected]>
clubanderson added a commit that referenced this pull request May 1, 2026
* 🐛 Fix incorrect assertion in agentFetch 401 retry test

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Copilot <[email protected]>

* test: batch 16 coverage — preflightCheck, useClusterContext, sampleData (#11192)

* test: add batch 16 coverage tests for preflightCheck, useClusterContext, sampleData

Add 116 tests across 3 files to push line coverage past 90.50%:
- preflightCheck-coverage (67 tests): classifyKubectlError, resolveRequiredTools, runToolPreflightCheck
- useClusterContext-coverage (17 tests): operator name stripping, helm chart parsing, pod issues
- sampleData-coverage (32 tests): field heuristics, detectFieldFormat edge cases

Signed-off-by: Andrew Anderson <[email protected]>

* fix: change savedCards/sharedDashboards to let for reassignment in resetShareRegistries

Signed-off-by: Andrew Anderson <[email protected]>

---------

Signed-off-by: Andrew Anderson <[email protected]>

* 🐛 Fix medium Copilot comments: GHE commit URL, stale cluster selection, type signatures

- feedback_config.go: add resolveGitHubUIBase() for GHE-aware web link construction
- feedback_github.go: use resolveGitHubUIBase() for SHA commit link (#11177 follow-up)
- ComplianceReports.tsx: clear selectedCluster when it's filtered out by reachability
  (was only auto-set when empty, leaving stale selection pointing to hidden cluster)
- ComplianceReports.tsx + ControlPlaneHealth.tsx: fix misleading 'only reachable'
  comments — predicate c.reachable !== false also includes undefined (not-yet-checked)
- dedup.ts: widen shareMetricsBetweenSameServerClusters signature to ClusterInfo[] |
  null | undefined to match the runtime guard already in the body (#11184 medium)
- shared.ts: fix dedup priority comment — reachability is criterion #1, not #2

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Copilot <[email protected]>

---------

Signed-off-by: Copilot <[email protected]>
Signed-off-by: Andrew Anderson <[email protected]>
Co-authored-by: Copilot <[email protected]>
lightyagami2109 pushed a commit to lightyagami2109/kubestellar_console_OJT that referenced this pull request May 3, 2026
lightyagami2109 pushed a commit to lightyagami2109/kubestellar_console_OJT that referenced this pull request May 3, 2026
…1202)

* 🐛 Fix incorrect assertion in agentFetch 401 retry test

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Copilot <[email protected]>

* test: batch 16 coverage — preflightCheck, useClusterContext, sampleData (kubestellar#11192)

* test: add batch 16 coverage tests for preflightCheck, useClusterContext, sampleData

Add 116 tests across 3 files to push line coverage past 90.50%:
- preflightCheck-coverage (67 tests): classifyKubectlError, resolveRequiredTools, runToolPreflightCheck
- useClusterContext-coverage (17 tests): operator name stripping, helm chart parsing, pod issues
- sampleData-coverage (32 tests): field heuristics, detectFieldFormat edge cases

Signed-off-by: Andrew Anderson <[email protected]>

* fix: change savedCards/sharedDashboards to let for reassignment in resetShareRegistries

Signed-off-by: Andrew Anderson <[email protected]>

---------

Signed-off-by: Andrew Anderson <[email protected]>

* 🐛 Fix medium Copilot comments: GHE commit URL, stale cluster selection, type signatures

- feedback_config.go: add resolveGitHubUIBase() for GHE-aware web link construction
- feedback_github.go: use resolveGitHubUIBase() for SHA commit link (kubestellar#11177 follow-up)
- ComplianceReports.tsx: clear selectedCluster when it's filtered out by reachability
  (was only auto-set when empty, leaving stale selection pointing to hidden cluster)
- ComplianceReports.tsx + ControlPlaneHealth.tsx: fix misleading 'only reachable'
  comments — predicate c.reachable !== false also includes undefined (not-yet-checked)
- dedup.ts: widen shareMetricsBetweenSameServerClusters signature to ClusterInfo[] |
  null | undefined to match the runtime guard already in the body (kubestellar#11184 medium)
- shared.ts: fix dedup priority comment — reachability is criterion kubestellar#1, not kubestellar#2

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Copilot <[email protected]>

---------

Signed-off-by: Copilot <[email protected]>
Signed-off-by: Andrew Anderson <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: lightyagami2109 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tier/2-standard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Docs feedback commit URL points to wrong repo when repoName=="docs"

3 participants