fix(workloads): catch silent multi-cluster propagation failures and unhandled rejections by pulkitvats2007-crypto · Pull Request #11114 · kubestellar/console

pulkitvats2007-crypto · 2026-04-30T17:49:43Z

📌 Fixes

📝 Summary of Changes

This PR fixes critical issues in workload orchestration where API failures were silently ignored and promise rejections were left unhandled, leading to misleading UI states and potential multi-cluster drift.

Ensures frontend hooks validate logical API success (success: false) instead of relying solely on HTTP status
Prevents unhandled promise rejections in dashboard runtime
Adds comprehensive test coverage for failure scenarios

Changes Made

Fixed silent API failure handling in useDeployWorkload, useScaleWorkload, and useDeleteWorkload
Added validation for result.success === false and throw appropriate errors
Prevented false-positive onSuccess callbacks on failed operations
Fixed unhandled promise rejection in handleDeployWorkload by appending .catch(console.error)
Added unit tests for:
- HTTP 200 OK + success: false in deploy workflow
- HTTP 200 OK + success: false in scale workflow
- HTTP 200 OK + success: false in delete workflow

Checklist

Please ensure the following before submitting your PR:

I used a coding agent (Claude Code, Copilot, Gemini, or Codex) to generate/review this code
I have reviewed the project's contribution guidelines
New cards target https://github.com/kubestellar/console-marketplace, not this repo
isDemoData is wired correctly (cards show Demo badge when using demo data)
I have written unit tests for the changes (if applicable)
I have tested the changes locally and ensured they work as expected
All commits are signed with DCO (git commit -s)

Screenshots or Logs (if applicable)

N/A (logic-level fix, no UI changes)

👀 Reviewer Notes

Root Issue:
Frontend hooks were incorrectly treating HTTP 200 responses as success, even when the backend explicitly returned { success: false } for failed multi-cluster propagation operations.

Impact:

False success notifications in UI ("Deployed successfully")
Silent configuration drift across clusters
Unhandled promise rejections causing instability in dashboard runtime

Fix Highlights:

Added explicit validation of result.success before invoking onSuccess
Errors are now properly thrown and propagated to UI
Ensured all async mutations are safely handled with .catch(...)

Result:
Accurate error reporting, elimination of silent failures, and improved reliability of multi-cluster workload orchestration.

…ctions Signed-off-by: pulkitvats2007-crypto <[email protected]>

kubestellar-prow · 2026-04-30T17:49:47Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2026-04-30T17:49:49Z

✅ Deploy Preview for kubestellarconsole ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`928957b`
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/69f398cd0a19530008753df5
😎 Deploy Preview	https://deploy-preview-11114.console-deploy-preview.kubestellar.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-04-30T17:49:53Z

👋 Hey @pulkitvats2007-crypto — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

Claude Code (Opus 4.5 / 4.6) — recommended

GitHub Copilot

Cursor

Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

github-actions · 2026-04-30T17:49:55Z

👋 Welcome to the KubeStellar community! 💖

Thanks and congrats 🎉 for opening your first PR here! We're excited to have you contributing.

Before merge, please ensure:

✅ DCO Sign-off — All commits signed with git commit -s (DCO)
✅ PR Title — Starts with an emoji: ✨ feature | 🐛 bug fix | 📖 docs | 🌱 infra/tests | ⚠️ breaking

📬 If you're using KubeStellar in your organization, please add your name to our Adopters list. 🙏 It really helps the project gain momentum and credibility — a small contribution back with a big impact.

Resources:

🖥️ KubeStellar Console — Try the live multi-cluster dashboard
📖 Console Docs — Installation, features, and architecture
🧩 Marketplace — Community extensions and cards
📚 Knowledge Base — Troubleshooting and how-tos
📖 Full Documentation | 🤝 Contributor Handbook | 💬 Slack

A maintainer will review your PR soon. Hope you have a great time here!

🌟 ~~~~~~~~~~ 🌟

📬 If you like KubeStellar, please ⭐ star ⭐ our repo to support it!

🙏 It really helps the project gain momentum and credibility — a small contribution back with a big impact.

Copilot

Pull request overview

Improves reliability of workload orchestration in the web console by ensuring logical API failures ({ success: false }) are surfaced as errors (instead of being treated as success on HTTP 200), and by preventing an unhandled promise rejection in the dashboard runtime.

Changes:

Add explicit result.success === false handling in workload deploy/scale/delete hooks to throw and route errors through existing error paths.
Prevent unhandled promise rejection when triggering deploy from the dashboard runtime by attaching a .catch(...).
Add unit tests covering HTTP 200 responses that still indicate failure via success: false.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
web/src/lib/dashboards/DashboardRuntime.tsx	Adds a rejection handler to avoid unhandled promise rejections for fire-and-forget deploy mutation calls.
web/src/hooks/useWorkloads.ts	Treats `{ success: false }` as failure for deploy/scale/delete mutations, preventing false-positive UI success.
web/src/hooks/tests/useWorkloads.test.ts	Adds tests for “HTTP 200 but `success: false`” failure scenarios for deploy/scale/delete hooks.

…ss is not called on failure Signed-off-by: pulkitvats2007-crypto <[email protected]>

github-actions · 2026-04-30T18:17:42Z

✅ Post-Merge Verification: passed

Commit: 61c57e80948293d8d9fc0bafd9296da46a26fe15
Specs run: smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/25181787198

…nhandled rejections (kubestellar#11114) * fix(workloads): handle silent propagation failures and unhandled rejections Signed-off-by: pulkitvats2007-crypto <[email protected]> * test: align success response mocks to object shape and assert onSuccess is not called on failure Signed-off-by: pulkitvats2007-crypto <[email protected]> --------- Signed-off-by: pulkitvats2007-crypto <[email protected]> Signed-off-by: lightyagami2109 <[email protected]>

fix(workloads): handle silent propagation failures and unhandled reje…

05ae43b

…ctions Signed-off-by: pulkitvats2007-crypto <[email protected]>

Copilot AI review requested due to automatic review settings April 30, 2026 17:49

kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Apr 30, 2026

kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 30, 2026

github-actions Bot added the tier/2-standard label Apr 30, 2026

Copilot started reviewing on behalf of pulkitvats2007-crypto April 30, 2026 17:50 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread web/src/hooks/__tests__/useWorkloads.test.ts

Comment thread web/src/hooks/__tests__/useWorkloads.test.ts

Comment thread web/src/hooks/__tests__/useWorkloads.test.ts

Comment thread web/src/hooks/useWorkloads.ts

Comment thread web/src/hooks/useWorkloads.ts

test: align success response mocks to object shape and assert onSucce…

928957b

…ss is not called on failure Signed-off-by: pulkitvats2007-crypto <[email protected]>

kubestellar-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2026

clubanderson merged commit 61c57e8 into kubestellar:main Apr 30, 2026
35 of 36 checks passed

clubanderson mentioned this pull request Apr 30, 2026

🐛 1 test failure(s) in Coverage Suite run #1846 #11115

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(workloads): catch silent multi-cluster propagation failures and unhandled rejections#11114

fix(workloads): catch silent multi-cluster propagation failures and unhandled rejections#11114
clubanderson merged 2 commits intokubestellar:mainfrom
pulkitvats2007-crypto:fix-unhandled-workload-failures

pulkitvats2007-crypto commented Apr 30, 2026

Uh oh!

kubestellar-prow Bot commented Apr 30, 2026

Uh oh!

netlify Bot commented Apr 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

pulkitvats2007-crypto commented Apr 30, 2026

📌 Fixes

📝 Summary of Changes

Changes Made

Checklist

Screenshots or Logs (if applicable)

👀 Reviewer Notes

Uh oh!

kubestellar-prow Bot commented Apr 30, 2026

Uh oh!

netlify Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubestellarconsole ready!

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026

✅ Post-Merge Verification: passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify Bot commented Apr 30, 2026 •

edited

Loading