Copilot Review Comments
PR #8360 (✨ Educational intro modal on /acmm + grammar fix) was merged with 3 Copilot review comment(s) that should be addressed in a follow-up:
- web/src/components/acmm/ACMMIntroModal.tsx:68: With
closeOnEscape={false}, the header’s default close button tooltip still says "Close (Esc)" (from BaseModal.Header). This is misleading UX for a sticky modal. Consider hiding the default close bu...
- web/src/components/acmm/ACMMIntroModal.tsx:189: BaseModal.Footer shows default keyboard hints (Esc/Space to close), but this modal disables Escape (and should likely disable Space/Backspace as well). Leaving the default hints on will tell users the...
- web/src/components/acmm/ACMMIntroModal.tsx:59: This modal is intended to be “sticky” (no backdrop/Escape close), but BaseModal also closes on Space/Backspace by default when
enableBackspace is true and no onBack is provided. As written, users ...
PR: #8360
Auto-generated by copilot-comment-followup workflow
Copilot Review Comments
PR #8360 (✨ Educational intro modal on /acmm + grammar fix) was merged with 3 Copilot review comment(s) that should be addressed in a follow-up:
closeOnEscape={false}, the header’s default close button tooltip still says "Close (Esc)" (from BaseModal.Header). This is misleading UX for a sticky modal. Consider hiding the default close bu...enableBackspaceis true and noonBackis provided. As written, users ...PR: #8360
Auto-generated by copilot-comment-followup workflow