Skip to content

[Copilot Review] 5 comment(s) on merged PR #8267 #8277

@github-actions

Description

@github-actions

Copilot Review Comments

PR #8267 (🐛 fix: address Copilot review on local LLM providers (#8255, #8259)) was merged with 5 Copilot review comment(s) that should be addressed in a follow-up:

  • pkg/agent/server_operations.go:348: BaseURLSource is documented as "env"/"config" or empty when the value is the compiled-in default (see KeyStatus.BaseURLSource docs in server_ai.go), but this sets it to the new string value "default...
  • pkg/agent/server_operations.go:355: For local LLM runners, Configured is derived from status.BaseURL != "" after you inject the compiled-in default. That makes Ollama/LM Studio show as configured even when the operator hasn’t set an...
  • pkg/agent/server_operations.go:318: handleGetKeysStatus now returns a populated providers list (instead of an empty list). There is an existing unit test (TestServer_SettingsHandlers in pkg/agent/server_test.go) that asserts the key...
  • web/src/components/agent/APIKeySettings.tsx:248: handleSaveBaseURL currently treats a blank Base URL the same as “no field provided” and will trigger the backend missing_field guard once clearBaseURL is introduced. To support the UI hint (“Lea...
  • pkg/agent/server_operations.go:348: KeyStatus.BaseURL is documented as the fully resolved base URL (env → config → compiled default), but status.BaseURL = cm.GetBaseURL(p.name) returns only env/config overrides and stays empty when ...

PR: #8267


Auto-generated by copilot-comment-followup workflow

Metadata

Metadata

Assignees

No one assigned

    Labels

    ai-generatedPull request generated by AIkind/enhancementEnhancement or improvementtriage/acceptedIndicates an issue or PR is ready to be actively worked on.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions