Skip to content

[Copilot Review] 5 comment(s) on merged PR #8256 #8259

@github-actions

Description

@github-actions

Copilot Review Comments

PR #8256 (✨ Settings → API Keys: Advanced Base URL field per local LLM provider (closes #8254)) was merged with 5 Copilot review comment(s) that should be addressed in a follow-up:

  • pkg/agent/server_operations.go:332: status.BaseURL is populated via cm.GetBaseURL(p.name), but GetBaseURL currently returns only the env/config override (empty when using the compiled-in default). This conflicts with the struct/AP...
  • pkg/agent/server_operations.go:405: The frontend hint says “Leave blank to use the compiled-in default”, but handleSetKey rejects requests where BaseURL is empty (and also treats an all-empty request as missing_field). This makes ...
  • pkg/agent/server_ai.go:1622: KeyStatus.BaseURL is documented here as the fully resolved base URL (env → config → compiled default), but the current implementation in handleGetKeysStatus sets it from ConfigManager.GetBaseURL...
  • web/src/components/agent/APIKeySettings.tsx:222: handleSaveBaseURL calls fetchKeysStatus() but it’s not included in the useCallback dependency list. This can capture a stale version of fetchKeysStatus (it changes when t changes) and will a...
  • pkg/agent/server_operations.go:322: Configured is currently derived only from cm.HasAPIKey(p.name), but for local LLM runners this endpoint is intended to treat “configured” as “URL present” (per the comment above and the PR descrip...

PR: #8256


Auto-generated by copilot-comment-followup workflow

Metadata

Metadata

Assignees

No one assigned

    Labels

    ai-generatedPull request generated by AIkind/enhancementEnhancement or improvementtriage/acceptedIndicates an issue or PR is ready to be actively worked on.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions