Copilot Review Comments
PR #8256 (✨ Settings → API Keys: Advanced Base URL field per local LLM provider (closes #8254)) was merged with 5 Copilot review comment(s) that should be addressed in a follow-up:
- pkg/agent/server_operations.go:332:
status.BaseURL is populated via cm.GetBaseURL(p.name), but GetBaseURL currently returns only the env/config override (empty when using the compiled-in default). This conflicts with the struct/AP...
- pkg/agent/server_operations.go:405: The frontend hint says “Leave blank to use the compiled-in default”, but
handleSetKey rejects requests where BaseURL is empty (and also treats an all-empty request as missing_field). This makes ...
- pkg/agent/server_ai.go:1622:
KeyStatus.BaseURL is documented here as the fully resolved base URL (env → config → compiled default), but the current implementation in handleGetKeysStatus sets it from ConfigManager.GetBaseURL...
- web/src/components/agent/APIKeySettings.tsx:222:
handleSaveBaseURL calls fetchKeysStatus() but it’s not included in the useCallback dependency list. This can capture a stale version of fetchKeysStatus (it changes when t changes) and will a...
- pkg/agent/server_operations.go:322:
Configured is currently derived only from cm.HasAPIKey(p.name), but for local LLM runners this endpoint is intended to treat “configured” as “URL present” (per the comment above and the PR descrip...
PR: #8256
Auto-generated by copilot-comment-followup workflow
Copilot Review Comments
PR #8256 (✨ Settings → API Keys: Advanced Base URL field per local LLM provider (closes #8254)) was merged with 5 Copilot review comment(s) that should be addressed in a follow-up:
status.BaseURLis populated viacm.GetBaseURL(p.name), butGetBaseURLcurrently returns only the env/config override (empty when using the compiled-in default). This conflicts with the struct/AP...handleSetKeyrejects requests whereBaseURLis empty (and also treats an all-empty request asmissing_field). This makes ...KeyStatus.BaseURLis documented here as the fully resolved base URL (env → config → compiled default), but the current implementation inhandleGetKeysStatussets it fromConfigManager.GetBaseURL...handleSaveBaseURLcallsfetchKeysStatus()but it’s not included in theuseCallbackdependency list. This can capture a stale version offetchKeysStatus(it changes whentchanges) and will a...Configuredis currently derived only fromcm.HasAPIKey(p.name), but for local LLM runners this endpoint is intended to treat “configured” as “URL present” (per the comment above and the PR descrip...PR: #8256
Auto-generated by copilot-comment-followup workflow