User Request
Type: bug
Target: Console Application
Submitted by: @aashu2006
Console Request ID: 85b0d6cb-e283-4e1d-9f28-2a5de28731e3
Description
What happened:
In pkg/api/handlers/analytics_proxy.go:20, &http.Client{Timeout: 10 * time.Second} uses a hardcoded magic number. Every other HTTP client in the package (youtube.go, medium.go, github_proxy.go) uses a named timeout constant.
What I expected:
A named constant analyticsClientTimeout = 10 * time.Second should be defined and used consistent with other handlers.
Steps to reproduce:
- Compare analytics_proxy.go:20 with youtube.go and medium.go timeout constants
- Observe the inconsistent magic number
This issue was automatically created from the KubeStellar Console.
User Request
Type: bug
Target: Console Application
Submitted by: @aashu2006
Console Request ID: 85b0d6cb-e283-4e1d-9f28-2a5de28731e3
Description
What happened:
In
pkg/api/handlers/analytics_proxy.go:20,&http.Client{Timeout: 10 * time.Second}uses a hardcoded magic number. Every other HTTP client in the package (youtube.go,medium.go,github_proxy.go) uses a named timeout constant.What I expected:
A named constant
analyticsClientTimeout = 10 * time.Secondshould be defined and used consistent with other handlers.Steps to reproduce:
This issue was automatically created from the KubeStellar Console.