Copilot Review Comments
PR #7768 (π fix(e2e): stabilize UX tests round 3 (14 failures β expect ~0)) was merged with 4 Copilot review comment(s) that should be addressed in a follow-up:
- web/e2e/user-flows/keyboard-navigation.spec.ts:110:
global-search-input is the navbar input (always visible), so using isVisible() to decide whether search opened is ineffective, and expect(searchInput).not.toBeVisible() after Escape is incorre...
- web/e2e/user-flows/find-and-search.spec.ts:28: This test no longer validates the keyboard shortcut:
global-search-input is already visible on the page, so checking isVisible() (and then only asserting visibility) will pass even if Ctrl/Meta+K ...
- web/e2e/user-flows/find-and-search.spec.ts:101:
collectConsoleErrors usage was removed in this test, but the file still imports it. That will typically fail TypeScript/ESLint no-unused-vars. Either drop the unused import or reintroduce a console-...
- web/e2e/helpers/ux-assertions.ts:152: The new console-error allowlist patterns are very broad (especially
/Access-Control-Allow-Origin/i) and can mask unrelated issues that mention that header. Consider narrowing these regexes to the sp...
PR: #7768
Auto-generated by copilot-comment-followup workflow
Copilot Review Comments
PR #7768 (π fix(e2e): stabilize UX tests round 3 (14 failures β expect ~0)) was merged with 4 Copilot review comment(s) that should be addressed in a follow-up:
global-search-inputis the navbar input (always visible), so usingisVisible()to decide whether search opened is ineffective, andexpect(searchInput).not.toBeVisible()afterEscapeis incorre...global-search-inputis already visible on the page, so checkingisVisible()(and then only asserting visibility) will pass even if Ctrl/Meta+K ...collectConsoleErrorsusage was removed in this test, but the file still imports it. That will typically fail TypeScript/ESLint no-unused-vars. Either drop the unused import or reintroduce a console-.../Access-Control-Allow-Origin/i) and can mask unrelated issues that mention that header. Consider narrowing these regexes to the sp...PR: #7768
Auto-generated by copilot-comment-followup workflow